Feature/update to gfdl 20210120 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge dev/emc
merge dev/emc
merge to latest dev/emc
Feature/logcleanup (NOAA-EMC#20)
nuopc_driver updates (NOAA-EMC#22)
* document wave coupling variables * switch ii jj loops for computational efficiency * clarify error message * fix indexing and style
remove duplicated declearation of function chkerr, change case to match
…20210120 This is corresponding GFDL 20210120 main branch commit (hash # fe5e605)
|
all coupled and data atm cases in RT passed except three bmark with wave related cases, as the fixing of missing halo in tau has not been included in ufs-weather-model yet. |
…120' into bugfix/li2016fix skip-ci
This patch fixes a sign bug, in both MCT and NUOPC, when accounting for the latent heat from fprec and frunnoff. Following MOM6's definition, both fprec and frunoff are > 0 into the ocean. Therefore, the latent heat associated with these terms should be negative.
Bugfix: sign error on fprec for nuopc and mct caps
|
@jiandewang I am going to start creating baselines for this PR. Once I've posted the logs for ufs-weather, I'll need to have this PR approved and merged so I can then update ufs-weather to point to the new develop commit. Just a heads up since we're implementing a new procedure at this point. |
DeniseWorthen
approved these changes
Jan 27, 2021
jiandewang
pushed a commit
to jiandewang/MOM6
that referenced
this pull request
Jun 17, 2021
Merge in dev/gfdl updates
jiandewang
pushed a commit
to jiandewang/MOM6
that referenced
this pull request
Feb 1, 2022
* Adds option to homogenize forces and fluxes fields - Adds functions to do global averages on U and V grids in MOM_spatial_means - Adds functionality to average all forcing and fluxes fields in MOM_forcing_types - Adds flag to average all forcing and fluxes in MOM.F90 - This new feature is primarily for running in single column like configurations with the coupler, which requires perfectly equal forcing across all cells. * Fixing ustar calculation in homogenize_mech_forcing - Adds in irho0 and sqrt that were missing in homogenize mech forcing. * Updates to homogenize_forcings options. - Correct issues in global_area_mean_u and global_area_mean_v to work with symmetric and rotated grids. - Add options to compute mean ustar or compute ustar from mean tau. - Add subroutines to replace averaging blocks in MOM_forcing_type. * Minor formatting updates - Move a division and reformat alignment in MOM_spatial_means.F90. - Remove a unused parameter in MOM_forcing_type.F90 - Reformat misalignment of an "if-block" in MOM_forcing_type.F90 * Remove obsolete netSalt flux homogenization - netSalt has been removed so no longer needs homogenized in the fluxes. * Fix 2d mean on U grid to use U mask * Remove whitespacace * Add do_not_log option to UPDATE_USTAR get_param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is for updating EMC MOM6 issue #50 , the code changes are minor (documentation enhancement) and no results change is expected in current ufs-weather-model RT. I am running RT now and will post log file here when they are done.