forked from mom-ocean/MOM6
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update to gfdl 20210503 #67
Merged
jiandewang
merged 46 commits into
NOAA-EMC:dev/emc
from
jiandewang:feature/update-to-GFDL-20210503
May 8, 2021
Merged
Feature/update to gfdl 20210503 #67
jiandewang
merged 46 commits into
NOAA-EMC:dev/emc
from
jiandewang:feature/update-to-GFDL-20210503
May 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n_code_LBD Delete forgotten code
* Also reducing line lenghts > 120
Fixes inconsistency in the calculation of tendency due to lateral diffusion
See https://arxiv.org/abs/2004.06278. Not an exact reproduction of "squares" because Fortran doesn't have a uint64 type, and not all compilers provide integers with > 64 bits...
…_diff Adds mask2dT checker to avoid calling boundary_k_range at land points
Added a counter-based PRNG to MOM_random
Remove an omp parallel do directive due to thread-unsafe cpu_clock
This patch fixes a sign bug, in both MCT and NUOPC, when accounting for the latent heat from fprec and frunnoff. Following MOM6's definition, both fprec and frunoff are > 0 into the ocean. Therefore, the latent heat associated with these terms should be negative.
* Fixes latent heat contribution from fprec and frunoff (MCT and NUOPC)
…ndidate_2021-02-19 Fix LBD module after merging main candidate 2021 02 19
Merge main candidate 2021-02-19
Add med2mod_areacor and move where area correction is applied
Sync with main to bring in new file layout
…lux_areacorr Implements flux area correction factors in the NUOPC cap
add if clause to a set_diffusivity OMP block.
add support for threading in cmeps
…20210503 this is corresponding to GFDL main branch 20210503 commit (hash # e6ce6a8)
DeniseWorthen
approved these changes
May 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
update EMC MOM6 to GFDL 20210503 commit (see detail at https://github.com/NOAA-GFDL/MOM6/pull/1381#issuecomment-831473753)
Issues Fixed (include github issue #):
MOM6 closes #66
ufs-weather-model Issue No. 556 (ufs-community/ufs-weather-model#556)
Are changes expected to change answers?
No
Testing performed:
machine: orion, hera and dell-p3
Hashes used for testing
NEMS: cf1de1e0
CMEPS: 037cbe92
FV3: ce81602
CICE: 2eca569
WW3: 2646f8c1
stochastic_physics: 6e4d5ce0
MOM6: 819267f (https://github.com/jiandewang/MOM6/tree/feature/update-to-GFDL-20210503)