-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index format 2 will not handle all > 2 GB files #653
Labels
bug
Something isn't working
Comments
@AlysonStahl-NOAA and @AlexanderRichert-NOAA this will be a problem for tocgrib2 as well. |
This was referenced May 7, 2024
This was referenced May 14, 2024
Closed
Merged
This was referenced May 22, 2024
Merged
Merged
OK, this has been a ton of work, but the index file now uses 8-byte ints everywhere that it should. The only thing left for this issue is to inspect the code for cases where I still use 4-byte ints internally. All these values need to be 8-byte everywhere in the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Unfortunately, based on a conversation with @webisu I have learned that further modifications are required for index format 2 to work on all large GRIB2 files.
Large GRIB2 files will have sections < 2 GB. But since they can be 2 GB, indexes to a section within a message must be 8-byte ints. Currently we use 4-byte ints. We need to change to 8 byte ints.
The text was updated successfully, but these errors were encountered: