Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index format 2 will not handle all > 2 GB files #653

Closed
edwardhartnett opened this issue Apr 22, 2024 · 2 comments · Fixed by #704
Closed

Index format 2 will not handle all > 2 GB files #653

edwardhartnett opened this issue Apr 22, 2024 · 2 comments · Fixed by #704
Assignees
Labels
bug Something isn't working

Comments

@edwardhartnett
Copy link
Contributor

Unfortunately, based on a conversation with @webisu I have learned that further modifications are required for index format 2 to work on all large GRIB2 files.

Large GRIB2 files will have sections < 2 GB. But since they can be 2 GB, indexes to a section within a message must be 8-byte ints. Currently we use 4-byte ints. We need to change to 8 byte ints.

@edwardhartnett edwardhartnett added the bug Something isn't working label Apr 22, 2024
@edwardhartnett edwardhartnett self-assigned this Apr 22, 2024
@edwardhartnett
Copy link
Contributor Author

@AlysonStahl-NOAA and @AlexanderRichert-NOAA this will be a problem for tocgrib2 as well.

@edwardhartnett
Copy link
Contributor Author

OK, this has been a ton of work, but the index file now uses 8-byte ints everywhere that it should.

The only thing left for this issue is to inspect the code for cases where I still use 4-byte ints internally. All these values need to be 8-byte everywhere in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant