Fix index 1 vs. 2 bug in g2getgb2.F90 #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderRichert-NOAA
changed the title
AlexanderRichert-NOAA
changed the title
|
OK, this is a good fix, thanks! I'm going to merge it... |
edwardhartnett
approved these changes
May 9, 2024
edwardhartnett
changed the title
|
@AlexanderRichert-NOAA also can you provide a test for this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem with extract=.true. for RRFS files with tocgrib2. This change doesn't seem to break the unit tests (namely, test_files).
Part of #653