Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converted some index values to 8-byte #660

Merged
merged 25 commits into from
May 10, 2024
Merged

Conversation

edwardhartnett
Copy link
Contributor

@edwardhartnett edwardhartnett commented May 6, 2024

Part of #653

Converting some 4-byte values in the index to 8-byte values in the index.

@edwardhartnett edwardhartnett marked this pull request as ready for review May 7, 2024 08:30
@edwardhartnett edwardhartnett changed the title Ejh fix 2 0506 converted some index values to 8-byte May 7, 2024
@AlexanderRichert-NOAA
Copy link
Contributor

Testing this with tocgrib2 and the test file from the RRFS devs, if I use getgb2p, it segfaults (on the line where it sets the first of the four 7's), and if I use getgb2p2, it doesn't seem to resolve the missing 7777 problem.

@edwardhartnett
Copy link
Contributor Author

edwardhartnett commented May 9, 2024

It would be helpful if you could approve this and I can merge it, as I continue to solve the problems with > 2GB that I recently learned of from Wesley.

I'm not working on the 7777 problem yet, but the first step will be an automated test that demonstrates the problem. Do we have that yet?

Is the 7777 problem in tocgrib2 or g2? Do we know? If it is in g2, we should have a g2 test that demonstrates it without involving tocgrib2.

Is there an issue for the 7777 problem? If not, can you create one?

@AlexanderRichert-NOAA
Copy link
Contributor

Yes the issue is in g2, I just created an issue for it: #666
@edwardhartnett if you're able to keep on with the coding side I can work on setting up a CTest test using the RRFS file.

@edwardhartnett edwardhartnett merged commit 853cba4 into develop May 10, 2024
54 checks passed
@edwardhartnett edwardhartnett deleted the ejh_fix_2_0506 branch May 10, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants