Add copygb test for NCEP grids 172 and 220. #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, I think what we want to do here is release a new version of w3emc, and then enforce that that is the version found by grib_util. I will do this... |
|
@GeorgeGayno-NOAA can you merge develop into this branch? I have fixed the MacOS problem in the CI, so it should work now. |
required for new test. Fixes NOAA-EMC#202.
|
@edwardhartnett The new copygb tests require a new w3emc release. The workflows that use the head of 'develop' are passing. Those that use release 2.9.3 or earlier are failing. |
|
OK, this has been open forever! @GeorgeGayno-NOAA if you can comment out the new tests in your cmake file we can merge this and I can submit another PR that turns on these tests when we are using the correct versions of w3emc. |
implemented. Fixes NOAA-EMC#220.
edwardhartnett
approved these changes
Jun 23, 2023
This was referenced Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test interpolates GFS land mask data to grids 172 and 220 and compares the output to baseline files.
Note: this test depends on a bug fix in the w3emc library. See: NOAA-EMC/NCEPLIBS-w3emc#158
Part of #202.