-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct specification of NCEP grids 172 and 220 #158
Correct specification of NCEP grids 172 and 220 #158
Conversation
to the correct values - grids 172 and 220. Fixes NOAA-EMC#157.
Fixes NOAA-EMC#157.
I added a unit test. But a more robust check would include a mapping of data to grids 172 and 220 using copygb. That could be done here: https://github.com/NOAA-EMC/NCEPLIBS-grib_util/blob/develop/tests/run_copygb_tests.sh Thoughts? The change to w3emc would need to be coordinated with the change to grib_util. |
@@ -0,0 +1,59 @@ | |||
program test_w3fi71 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for the test!!
Yes by all means add the test in grib_utils as well. We can coordinate releases. We have just updated a lot of build stuff having to do with shared vs. static, and we can do a bunch of releases to get the new build stuff out everywhere. |
Are you ready for this to me merged? If so, click "Ready for review" and I will merge it. |
A test version of copygb was compiled on Cactus using my bug fix branch: @malloryprow just tested it and said it is working. |
I added a test to copygb. For details, see: NOAA-EMC/NCEPLIBS-grib_util#203
|
Update w3fi71.f, which specifies the GRIB1 grid description section for NCEP
pre-defined grids, to correct errors with grids 172 and 220.
New unit test for w3fi71.f.
Fixes #157.