Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct specification of NCEP grids 172 and 220 #158

Merged
merged 6 commits into from
Jan 17, 2023

Conversation

GeorgeGayno-NOAA
Copy link
Contributor

@GeorgeGayno-NOAA GeorgeGayno-NOAA commented Jan 12, 2023

Update w3fi71.f, which specifies the GRIB1 grid description section for NCEP
pre-defined grids, to correct errors with grids 172 and 220.

New unit test for w3fi71.f.

Fixes #157.

@GeorgeGayno-NOAA
Copy link
Contributor Author

I added a unit test. But a more robust check would include a mapping of data to grids 172 and 220 using copygb. That could be done here: https://github.com/NOAA-EMC/NCEPLIBS-grib_util/blob/develop/tests/run_copygb_tests.sh

Thoughts? The change to w3emc would need to be coordinated with the change to grib_util.

@@ -0,0 +1,59 @@
program test_w3fi71
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the test!!

@edwardhartnett
Copy link
Contributor

Yes by all means add the test in grib_utils as well.

We can coordinate releases. We have just updated a lot of build stuff having to do with shared vs. static, and we can do a bunch of releases to get the new build stuff out everywhere.

@edwardhartnett
Copy link
Contributor

Are you ready for this to me merged? If so, click "Ready for review" and I will merge it.

@GeorgeGayno-NOAA
Copy link
Contributor Author

A test version of copygb was compiled on Cactus using my bug fix branch:
/lfs/h2/emc/global/noscrub/George.Gayno/mallory/copygb/NCEPLIBS-grib_util/exec/copygb.4.mallory

@malloryprow just tested it and said it is working.

@GeorgeGayno-NOAA GeorgeGayno-NOAA marked this pull request as ready for review January 17, 2023 14:08
@GeorgeGayno-NOAA
Copy link
Contributor Author

Yes by all means add the test in grib_utils as well.

I added a test to copygb. For details, see: NOAA-EMC/NCEPLIBS-grib_util#203

We can coordinate releases. We have just updated a lot of build stuff having to do with shared vs. static, and we can do a bunch of releases to get the new build stuff out everywhere.

@edwardhartnett edwardhartnett merged commit 408d739 into NOAA-EMC:develop Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NCEP grids 172 and 220 not defined correctly in w3fi71.f
2 participants