Update FV3-LAM flat files and ncep_post executable names #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBeck-NOAA
changed the title
|
@JeffBeck-NOAA Do you have corresponding xml files for fv3lam and fv3lam_goes flat files? It would be better for keeping a pair of xml |
@WenMeng-NOAA, I can also rename the related XML files. I'll go ahead and push a commit to do that. |
|
@JeffBeck-NOAA Would you also change sar to lam in parm/makefile? |
4 tasks
@WenMeng-NOAA, done! |
|
@JeffBeck-NOAA Now it is in a good shape. I will proceed code reviewing testing. Thanks! |
|
@EricRogers-NOAA and @BenjaminBlake-NOAA Please review this PR for renaming UPP control files for FV3 LAM/LAMX. Thanks! |
|
@WenMeng-NOAA This PR looks good to me so I'll go ahead and approve it |
BenjaminBlake-NOAA
approved these changes
Dec 9, 2020
WenMeng-NOAA
approved these changes
Dec 10, 2020
|
The regression tests were conducted on Dell, Cray and Hera. No changed results were found. This PR is ready for merging. |
BoCui-NOAA
added a commit
to BoCui-NOAA/EMC_post
that referenced
this pull request
Dec 11, 2020
Update FV3-LAM flat files and ncep_post executable names (NOAA-EMC#237)
mkavulich
added a commit
to ufs-community/ufs-srweather-app
that referenced
this pull request
Dec 11, 2020
## DESCRIPTION OF CHANGES: Currently master is broken and will not build and/or run on any platform due to incompatible hashes and outdated changes. Several fixes are needed to get master back in working order, most of which will be included in this PR. The direct changes made in ufs-srweather-app for this PR are: - Partially cherry-picking release-branch changes to update build system and documentation - Updating static hashes to the latest versions of `develop` branches for ufs-weather-model, EMC_post, UFS_UTILS, and regional_workflow Some changes that were needed prior to this PR being merged are: - [x] EMC_post needs to be updated to include an updated executable name and flat config files - NOAA-EMC/UPP#237 - [x] regional_workflow needs to be updated for the new ufs-weather-model executable name - https://github.com/NOAA-EMC/regional_workflow/pull/374 - [x] regional_workflow also needs to be updated for changed namelist options in the latest ufs-weather-model develop branch - https://github.com/NOAA-EMC/regional_workflow/pull/377 - [x] regional_workflow also needs to be updated with the commit in https://github.com/NOAA-EMC/regional_workflow/pull/343 in order for the workflow and automated tests to work on Cheyenne - https://github.com/NOAA-EMC/regional_workflow/pull/378 These PRs have been merged and this PR updated with the latest hashes. ## TESTS CONDUCTED: Compiles and workflow is successfully generated on Cheyenne, Hera, and Jet; ran many tests that all passed; reference PR on Github for full list. ## ISSUE: Resolves #57
christinaholtNOAA
pushed a commit
to christinaholtNOAA/ufs-srweather-app
that referenced
this pull request
Dec 14, 2020
## DESCRIPTION OF CHANGES: Currently master is broken and will not build and/or run on any platform due to incompatible hashes and outdated changes. Several fixes are needed to get master back in working order, most of which will be included in this PR. The direct changes made in ufs-srweather-app for this PR are: - Partially cherry-picking release-branch changes to update build system and documentation - Updating static hashes to the latest versions of `develop` branches for ufs-weather-model, EMC_post, UFS_UTILS, and regional_workflow Some changes that were needed prior to this PR being merged are: - [x] EMC_post needs to be updated to include an updated executable name and flat config files - NOAA-EMC/UPP#237 - [x] regional_workflow needs to be updated for the new ufs-weather-model executable name - https://github.com/NOAA-EMC/regional_workflow/pull/374 - [x] regional_workflow also needs to be updated for changed namelist options in the latest ufs-weather-model develop branch - https://github.com/NOAA-EMC/regional_workflow/pull/377 - [x] regional_workflow also needs to be updated with the commit in https://github.com/NOAA-EMC/regional_workflow/pull/343 in order for the workflow and automated tests to work on Cheyenne - https://github.com/NOAA-EMC/regional_workflow/pull/378 These PRs have been merged and this PR updated with the latest hashes. ## TESTS CONDUCTED: Compiles and workflow is successfully generated on Cheyenne, Hera, and Jet; ran many tests that all passed; reference PR on Github for full list. ## ISSUE: Resolves ufs-community#57
christinaholtNOAA
pushed a commit
to christinaholtNOAA/ufs-srweather-app
that referenced
this pull request
Dec 14, 2020
## DESCRIPTION OF CHANGES: Currently master is broken and will not build and/or run on any platform due to incompatible hashes and outdated changes. Several fixes are needed to get master back in working order, most of which will be included in this PR. The direct changes made in ufs-srweather-app for this PR are: - Partially cherry-picking release-branch changes to update build system and documentation - Updating static hashes to the latest versions of `develop` branches for ufs-weather-model, EMC_post, UFS_UTILS, and regional_workflow Some changes that were needed prior to this PR being merged are: - [x] EMC_post needs to be updated to include an updated executable name and flat config files - NOAA-EMC/UPP#237 - [x] regional_workflow needs to be updated for the new ufs-weather-model executable name - https://github.com/NOAA-EMC/regional_workflow/pull/374 - [x] regional_workflow also needs to be updated for changed namelist options in the latest ufs-weather-model develop branch - https://github.com/NOAA-EMC/regional_workflow/pull/377 - [x] regional_workflow also needs to be updated with the commit in https://github.com/NOAA-EMC/regional_workflow/pull/343 in order for the workflow and automated tests to work on Cheyenne - https://github.com/NOAA-EMC/regional_workflow/pull/378 These PRs have been merged and this PR updated with the latest hashes. ## TESTS CONDUCTED: Compiles and workflow is successfully generated on Cheyenne, Hera, and Jet; ran many tests that all passed; reference PR on Github for full list. ## ISSUE: Resolves ufs-community#57
EricJames-NOAA
pushed a commit
to EricJames-NOAA/UPP
that referenced
this pull request
Dec 14, 2022
* Remove all references to /lfs3 on Jet * Add Ben and Ratko to the CODEOWNERS file * Replace hard-coded make_orog module file with build-level module file in UFS_UTILS * Remove hard-coded make_sfc_climo module file * Changes to allow definition of do_shum, do_sppt, and do_skeb options in the config.sh file * Add user-definable options for most ad-hoc stochastic physics settings * Fix typo in config_defaults.sh * Syntax fix in setup.sh * Merge in develop changes to moduleloads into feature/stochastic * Add loop to modulefiles in generate script * Introduce module load loop in generate script.
EricJames-NOAA
pushed a commit
to EricJames-NOAA/UPP
that referenced
this pull request
Dec 14, 2022
…NOAA-EMC#237) * Add namelist print_diff_pgr = .true. to turn on pressure tendency diagnostic * Add print_diff_pgr to config.sh.RRFS_NA_3km
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to discussion in Issue #145, the post executable in the develop branch has been renamed ncep_post and the FV3-LAM-relevant flat files were renamed to include the FV3-LAM acronym instead of FV3-SAR. These changes bring the develop branch in line with the release/public-v2 branch.
@WenMeng-NOAA @mkavulich