-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master inconsistent with regional_workflow/develop #57
Closed
christinaholtNOAA opened this issue
Nov 18, 2020
· 2 comments
· Fixed by ufs-community/regional_workflow#374
Closed
Master inconsistent with regional_workflow/develop #57
christinaholtNOAA opened this issue
Nov 18, 2020
· 2 comments
· Fixed by ufs-community/regional_workflow#374
Comments
The problem occurs when sourcing the README files, since those in the develop branch still contain system commands related to the build. @mkavulich, would you be willing to open a PR for your "update_documentation" branch into the develop branch of ufs-srweatherapp? |
This was referenced Dec 6, 2020
mkavulich
added a commit
to ufs-community/regional_workflow
that referenced
this issue
Dec 10, 2020
## DESCRIPTION OF CHANGES: The develop branch of ufs-weather-model was updated a couple months ago so that the weather model is no longer built as "NEMS.exe" (ufs-community/ufs-weather-model#217). The workflow generation script needs to be updated with the new model executable name: ufs_model. This PR will need to be merged in order to use regional_workflow and the ufs-srweather-app with the most up-to-date develop branch of ufs-weather-model. A PR will be upcoming to update ufs-srweather-app to point to this hash once this PR is merged. ## TESTS CONDUCTED: Ran generation script successfully with fully updated workflow. ## ISSUE (optional): This is necessary (but not sufficient) in order to resolve ufs-community/ufs-srweather-app#57
This was closed in error per direct communication with @mkavulich |
mkavulich
added a commit
to ufs-community/regional_workflow
that referenced
this issue
Dec 11, 2020
## DESCRIPTION OF CHANGES: Part of the effort described in ufs-community/ufs-srweather-app#71 to update the master branch of ufs-srweather-app to a functioning state. Updates include: - Cherry-picking 5a4b90e from release branch in order to include the RRFS_v1alpha CCPP suite, as well as fixing some updated namelist settings in the ufs-weather-model - Fixing other namelist options that have been updated in ufs-weather-model This PR must be merged prior to ufs-community/ufs-srweather-app#71, then that PR updated to point to this PR's hash. ## TESTS CONDUCTED: The following end-to-end tests are now all successful on Hera: - DOT_OR_USCORE - GST_release_public_v1 - get_extrn_files_from_hpss_FV3GFS_FV3GFS - get_extrn_files_from_hpss_GSMGFS_GSMGFS - get_extrn_files_from_hpss_HRRR_RAP - get_extrn_files_from_hpss_RAP_RAP - grid_GSD_HRRR_AK_50km - grid_GSD_RAP13km - grid_RRFS_AK_13km_FV3GFS_FV3GFS - grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 - grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16beta - grid_RRFS_CONUS_13km_ics_HRRR_lbcs_RAP_suite_GSD_SAR - grid_RRFS_CONUS_13km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta - grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 - grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16beta - grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_GSD_SAR - grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta - new_ESGgrid - new_GFDLgrid - new_GFDLgrid__GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES_eq_FALSE - new_GFDLgrid__GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES_eq_TRUE - regional_001 - regional_002 - suite_FV3_GFS_v15p2 - suite_FV3_GFS_v16beta - suite_FV3_GSD_SAR - suite_FV3_GSD_v0 - suite_FV3_RRFS_v1beta The following end-to-end tests were successful on Jet: - DOT_OR_USCORE - get_extrn_files_from_hpss_FV3GFS_FV3GFS - get_extrn_files_from_hpss_GSMGFS_GSMGFS - get_extrn_files_from_hpss_HRRR_RAP - get_extrn_files_from_hpss_RAP_RAP - grid_RRFS_AK_13km_FV3GFS_FV3GFS - grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 - grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16beta - grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 - grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16beta - new_ESGgrid - new_GFDLgrid - new_GFDLgrid__GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES_eq_FALSE - regional_001 - regional_002 - suite_FV3_GFS_v16beta A few tests on Hera and Jet are still failing, but they are known errors and will be fixed at a later date. Cheyenne tests are failing but this is fixed by #378 ## ISSUE (optional): In conjunction with #378 and ufs-community/ufs-srweather-app#71, will solve ufs-community/ufs-srweather-app#57, fixing the master branch of ufs-srweather-app so everyone will be happy and nothing will be broken and we will all live happily ever after.
christinaholtNOAA
pushed a commit
to christinaholtNOAA/ufs-srweather-app
that referenced
this issue
Dec 14, 2020
## DESCRIPTION OF CHANGES: Currently master is broken and will not build and/or run on any platform due to incompatible hashes and outdated changes. Several fixes are needed to get master back in working order, most of which will be included in this PR. The direct changes made in ufs-srweather-app for this PR are: - Partially cherry-picking release-branch changes to update build system and documentation - Updating static hashes to the latest versions of `develop` branches for ufs-weather-model, EMC_post, UFS_UTILS, and regional_workflow Some changes that were needed prior to this PR being merged are: - [x] EMC_post needs to be updated to include an updated executable name and flat config files - NOAA-EMC/UPP#237 - [x] regional_workflow needs to be updated for the new ufs-weather-model executable name - https://github.com/NOAA-EMC/regional_workflow/pull/374 - [x] regional_workflow also needs to be updated for changed namelist options in the latest ufs-weather-model develop branch - https://github.com/NOAA-EMC/regional_workflow/pull/377 - [x] regional_workflow also needs to be updated with the commit in https://github.com/NOAA-EMC/regional_workflow/pull/343 in order for the workflow and automated tests to work on Cheyenne - https://github.com/NOAA-EMC/regional_workflow/pull/378 These PRs have been merged and this PR updated with the latest hashes. ## TESTS CONDUCTED: Compiles and workflow is successfully generated on Cheyenne, Hera, and Jet; ran many tests that all passed; reference PR on Github for full list. ## ISSUE: Resolves ufs-community#57
christinaholtNOAA
pushed a commit
to christinaholtNOAA/ufs-srweather-app
that referenced
this issue
Dec 14, 2020
## DESCRIPTION OF CHANGES: Currently master is broken and will not build and/or run on any platform due to incompatible hashes and outdated changes. Several fixes are needed to get master back in working order, most of which will be included in this PR. The direct changes made in ufs-srweather-app for this PR are: - Partially cherry-picking release-branch changes to update build system and documentation - Updating static hashes to the latest versions of `develop` branches for ufs-weather-model, EMC_post, UFS_UTILS, and regional_workflow Some changes that were needed prior to this PR being merged are: - [x] EMC_post needs to be updated to include an updated executable name and flat config files - NOAA-EMC/UPP#237 - [x] regional_workflow needs to be updated for the new ufs-weather-model executable name - https://github.com/NOAA-EMC/regional_workflow/pull/374 - [x] regional_workflow also needs to be updated for changed namelist options in the latest ufs-weather-model develop branch - https://github.com/NOAA-EMC/regional_workflow/pull/377 - [x] regional_workflow also needs to be updated with the commit in https://github.com/NOAA-EMC/regional_workflow/pull/343 in order for the workflow and automated tests to work on Cheyenne - https://github.com/NOAA-EMC/regional_workflow/pull/378 These PRs have been merged and this PR updated with the latest hashes. ## TESTS CONDUCTED: Compiles and workflow is successfully generated on Cheyenne, Hera, and Jet; ran many tests that all passed; reference PR on Github for full list. ## ISSUE: Resolves ufs-community#57
christinaholtNOAA
pushed a commit
to christinaholtNOAA/ufs-srweather-app
that referenced
this issue
Sep 7, 2021
mkavulich
added a commit
to mkavulich/ufs-srweather-app
that referenced
this issue
Aug 26, 2022
## DESCRIPTION OF CHANGES: The develop branch of ufs-weather-model was updated a couple months ago so that the weather model is no longer built as "NEMS.exe" (ufs-community/ufs-weather-model#217). The workflow generation script needs to be updated with the new model executable name: ufs_model. This PR will need to be merged in order to use regional_workflow and the ufs-srweather-app with the most up-to-date develop branch of ufs-weather-model. A PR will be upcoming to update ufs-srweather-app to point to this hash once this PR is merged. ## TESTS CONDUCTED: Ran generation script successfully with fully updated workflow. ## ISSUE (optional): This is necessary (but not sufficient) in order to resolve ufs-community#57
mkavulich
added a commit
to mkavulich/ufs-srweather-app
that referenced
this issue
Aug 26, 2022
## DESCRIPTION OF CHANGES: Part of the effort described in ufs-community#71 to update the master branch of ufs-srweather-app to a functioning state. Updates include: - Cherry-picking 5a4b90e7 from release branch in order to include the RRFS_v1alpha CCPP suite, as well as fixing some updated namelist settings in the ufs-weather-model - Fixing other namelist options that have been updated in ufs-weather-model This PR must be merged prior to ufs-community#71, then that PR updated to point to this PR's hash. ## TESTS CONDUCTED: The following end-to-end tests are now all successful on Hera: - DOT_OR_USCORE - GST_release_public_v1 - get_extrn_files_from_hpss_FV3GFS_FV3GFS - get_extrn_files_from_hpss_GSMGFS_GSMGFS - get_extrn_files_from_hpss_HRRR_RAP - get_extrn_files_from_hpss_RAP_RAP - grid_GSD_HRRR_AK_50km - grid_GSD_RAP13km - grid_RRFS_AK_13km_FV3GFS_FV3GFS - grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 - grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16beta - grid_RRFS_CONUS_13km_ics_HRRR_lbcs_RAP_suite_GSD_SAR - grid_RRFS_CONUS_13km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta - grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 - grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16beta - grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_GSD_SAR - grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta - new_ESGgrid - new_GFDLgrid - new_GFDLgrid__GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES_eq_FALSE - new_GFDLgrid__GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES_eq_TRUE - regional_001 - regional_002 - suite_FV3_GFS_v15p2 - suite_FV3_GFS_v16beta - suite_FV3_GSD_SAR - suite_FV3_GSD_v0 - suite_FV3_RRFS_v1beta The following end-to-end tests were successful on Jet: - DOT_OR_USCORE - get_extrn_files_from_hpss_FV3GFS_FV3GFS - get_extrn_files_from_hpss_GSMGFS_GSMGFS - get_extrn_files_from_hpss_HRRR_RAP - get_extrn_files_from_hpss_RAP_RAP - grid_RRFS_AK_13km_FV3GFS_FV3GFS - grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 - grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16beta - grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 - grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16beta - new_ESGgrid - new_GFDLgrid - new_GFDLgrid__GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES_eq_FALSE - regional_001 - regional_002 - suite_FV3_GFS_v16beta A few tests on Hera and Jet are still failing, but they are known errors and will be fixed at a later date. Cheyenne tests are failing but this is fixed by ufs-community#378 ## ISSUE (optional): In conjunction with ufs-community#378 and ufs-community#71, will solve ufs-community#57, fixing the master branch of ufs-srweather-app so everyone will be happy and nothing will be broken and we will all live happily ever after.
mkavulich
added a commit
that referenced
this issue
Sep 8, 2022
## DESCRIPTION OF CHANGES: Part of the effort described in #71 to update the master branch of ufs-srweather-app to a functioning state. Updates include: - Cherry-picking 10911bcb from release branch in order to include the RRFS_v1alpha CCPP suite, as well as fixing some updated namelist settings in the ufs-weather-model - Fixing other namelist options that have been updated in ufs-weather-model This PR must be merged prior to #71, then that PR updated to point to this PR's hash. ## TESTS CONDUCTED: The following end-to-end tests are now all successful on Hera: - DOT_OR_USCORE - GST_release_public_v1 - get_extrn_files_from_hpss_FV3GFS_FV3GFS - get_extrn_files_from_hpss_GSMGFS_GSMGFS - get_extrn_files_from_hpss_HRRR_RAP - get_extrn_files_from_hpss_RAP_RAP - grid_GSD_HRRR_AK_50km - grid_GSD_RAP13km - grid_RRFS_AK_13km_FV3GFS_FV3GFS - grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 - grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16beta - grid_RRFS_CONUS_13km_ics_HRRR_lbcs_RAP_suite_GSD_SAR - grid_RRFS_CONUS_13km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta - grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 - grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16beta - grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_GSD_SAR - grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta - new_ESGgrid - new_GFDLgrid - new_GFDLgrid__GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES_eq_FALSE - new_GFDLgrid__GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES_eq_TRUE - regional_001 - regional_002 - suite_FV3_GFS_v15p2 - suite_FV3_GFS_v16beta - suite_FV3_GSD_SAR - suite_FV3_GSD_v0 - suite_FV3_RRFS_v1beta The following end-to-end tests were successful on Jet: - DOT_OR_USCORE - get_extrn_files_from_hpss_FV3GFS_FV3GFS - get_extrn_files_from_hpss_GSMGFS_GSMGFS - get_extrn_files_from_hpss_HRRR_RAP - get_extrn_files_from_hpss_RAP_RAP - grid_RRFS_AK_13km_FV3GFS_FV3GFS - grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 - grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16beta - grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 - grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16beta - new_ESGgrid - new_GFDLgrid - new_GFDLgrid__GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES_eq_FALSE - regional_001 - regional_002 - suite_FV3_GFS_v16beta A few tests on Hera and Jet are still failing, but they are known errors and will be fixed at a later date. Cheyenne tests are failing but this is fixed by #378 ## ISSUE (optional): In conjunction with #378 and #71, will solve #57, fixing the master branch of ufs-srweather-app so everyone will be happy and nothing will be broken and we will all live happily ever after.
natalie-perlin
pushed a commit
to natalie-perlin/ufs-srweather-app
that referenced
this issue
Jun 2, 2024
…erturbations (ufs-community#386) * Update .gitmodules and submodule pointer for fv3atm for gsl/develop branch * RUC ice for gsl/develop (replaces ufs-community#47) (ufs-community#49)Implementation of RUC LSM ice model in CCPP * Squash-merge climbfuji:rucice_gfsv16dzmin into gsl/develop * Add kice=9 to tests/tests/fv3_ccpp_rap and tests/tests/fv3_ccpp_hrrr * Change NEW_BASELINE directory for gsl/develop to avoid conflicts with development work on the authoritative branches * Add KICE=9 to tests/tests/fv3_ccpp_gsd_unified_ugwp and tests/tests/fv3_ccpp_gsd_drag_suite_unified_ugwp * Revert change to .gitmodules and update submodule pointer for fv3atm * Update gsl/develop from develop 2020/12/08 (ufs-community#50) * Updates to stochastic_physics_wrapper (ufs-community#280) Fix to stochastic_physics_wrapper to allow for random patterns to update at a longer time-step than model * Update for Jet, bug fixes in running with frac_grid=T and GFDL MP, and in restarting with frac_grid=T (ufs-community#304) Update the modulefile for jet.intel to enable UPP v10.0.0. The hpc-stack v1.0.0 pre-release is used for this. Small changes are made to tests.rt.sh for jet.intel and gaea.intel (consistency with other platforms). The submodule pointer update for fv3atm addresses bugs in the ufs-weather-model with frac_grid=T and GFDL microphysics, and with restarting the model when frac_grid=T (from @shansun6 and @SMoorthi-emc). * Land stochastic perturbations (ufs-community#57)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With the update of regional_workflow with #PR 357, the master branch of SRWeather App no longer works. It appears that PR #45 merged to master would fix the problem of sourcing the README txt file. It is not clear to me if there are other inconsistencies between master here and develop in regional_workflow.
The text was updated successfully, but these errors were encountered: