Only build the two supported CCPP suites; allow user to overwrite default suites #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v1beta) for the release. Also, rather than hard-coding the list, allow for the "CCPP_SUITES" variable to be set to overwrite the default
mkavulich
requested review from
gsketefian,
JeffBeck-NOAA and
JulieSchramm
as code owners
natalie-perlin
pushed a commit
to natalie-perlin/ufs-srweather-app
that referenced
this pull request
Jun 2, 2024
…erturbations (ufs-community#386) * Update .gitmodules and submodule pointer for fv3atm for gsl/develop branch * RUC ice for gsl/develop (replaces ufs-community#47) (ufs-community#49)Implementation of RUC LSM ice model in CCPP * Squash-merge climbfuji:rucice_gfsv16dzmin into gsl/develop * Add kice=9 to tests/tests/fv3_ccpp_rap and tests/tests/fv3_ccpp_hrrr * Change NEW_BASELINE directory for gsl/develop to avoid conflicts with development work on the authoritative branches * Add KICE=9 to tests/tests/fv3_ccpp_gsd_unified_ugwp and tests/tests/fv3_ccpp_gsd_drag_suite_unified_ugwp * Revert change to .gitmodules and update submodule pointer for fv3atm * Update gsl/develop from develop 2020/12/08 (ufs-community#50) * Updates to stochastic_physics_wrapper (ufs-community#280) Fix to stochastic_physics_wrapper to allow for random patterns to update at a longer time-step than model * Update for Jet, bug fixes in running with frac_grid=T and GFDL MP, and in restarting with frac_grid=T (ufs-community#304) Update the modulefile for jet.intel to enable UPP v10.0.0. The hpc-stack v1.0.0 pre-release is used for this. Small changes are made to tests.rt.sh for jet.intel and gaea.intel (consistency with other platforms). The submodule pointer update for fv3atm addresses bugs in the ufs-weather-model with frac_grid=T and GFDL microphysics, and with restarting the model when frac_grid=T (from @shansun6 and @SMoorthi-emc). * Land stochastic perturbations (ufs-community#57)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
The fv3 dycore release/public-v2 branch is being updated (NOAA-EMC/fv3atm#190) to only include the two supported CCPP suites (FV3_GFS_v15p2 and FV3_RRFS_v1beta). Since CMake is currently hardcoded to build many more suites than this, I need to update the list to only include these two.
Additionally, I included logic to allow the user to overwrite the default suites on the command line, by including the line "-DCCPP_SUITES=suite1,suite2,etc." in the cmake command.
TESTS CONDUCTED:
NOTE: After this change is committed, all tests that do not use one of the above two CCPP suites will fail unless you specify a different set of suites at build time!
Successfully built the app on MacOS with gnu-10 compilers (using a pending UFS_UTILS change) and on Hera with intel. Ran the suggested core suite of tests on Hera, and all passed:
When I pass the flag "-DCCPP_SUITES=FV3_GFS_v15p2 " at the cmake step, the "RRFS_v1beta" tests fail as expected, since that suite is not built.
ISSUE:
I could have sworn there was an issue for removing the unsupported CCPP suites from the release branch, but I can't find it if it still exists...