Feature/update model namelist definitions #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elist definitions
…uite to the set of valid suites that can be used in the workflow. (ufs-community#361)
mkavulich
requested review from
BenjaminBlake-NOAA,
gsketefian,
JeffBeck-NOAA and
JulieSchramm
as code owners
|
Just took a cursory look at the code changes, everything looks good. Based on all successful tests listed and known failures that will be fixed in the future (13-km AK domain and CPT SDF crashes), I'm approving. |
JeffBeck-NOAA
approved these changes
Dec 10, 2020
This was referenced Dec 11, 2020
| @@ -11,11 +11,14 @@ | |||
|
|
|||
|
|
|||
| FV3_GSD_v0: | |||
| gfs_physics_nml: | |||
| effr_in: True | |||
There was a problem hiding this comment.
I'd suggest putting this in the file input.nml.FV3 to keep this section empty always. It will not be needed in the other sections unless you want set to False, or need to leave it out altogether.
There was a problem hiding this comment.
I was the one who added that line, and I definitely prefer putting it in input.nml.FV3, but I wasn't (and still am not) sure which suites require it to be set to False, or what the default value is in FV3 if it is not specified.
The whole approach to namelist settings needs to be changed so it is centralized in one place -- the ufs-weather-model repo -- i.e. we should get all required namelist settings for each suite from the ufs-weather-model repo instead of setting them here and risking our settings being wrong or becoming outdated.
| @@ -139,7 +139,8 @@ | |||
| debug = .false. | |||
| do_mynnedmf = .true. | |||
| do_mynnsfclay = .false. | |||
| do_sfcperts = .false. | |||
| lndp_type = 0 | |||
| n_var_lndp = 0 | |||
There was a problem hiding this comment.
In general, keeping these lists alphabetically organized makes it easier to find items..
There was a problem hiding this comment.
I agree. I try, but it degrades over time as different users contribute changes. Occasional cleanup will be needed.
mkavulich
referenced
this pull request
in ufs-community/ufs-srweather-app
Dec 11, 2020
## DESCRIPTION OF CHANGES: Currently master is broken and will not build and/or run on any platform due to incompatible hashes and outdated changes. Several fixes are needed to get master back in working order, most of which will be included in this PR. The direct changes made in ufs-srweather-app for this PR are: - Partially cherry-picking release-branch changes to update build system and documentation - Updating static hashes to the latest versions of `develop` branches for ufs-weather-model, EMC_post, UFS_UTILS, and regional_workflow Some changes that were needed prior to this PR being merged are: - [x] EMC_post needs to be updated to include an updated executable name and flat config files - NOAA-EMC/UPP#237 - [x] regional_workflow needs to be updated for the new ufs-weather-model executable name - https://github.com/NOAA-EMC/regional_workflow/pull/374 - [x] regional_workflow also needs to be updated for changed namelist options in the latest ufs-weather-model develop branch - https://github.com/NOAA-EMC/regional_workflow/pull/377 - [x] regional_workflow also needs to be updated with the commit in https://github.com/NOAA-EMC/regional_workflow/pull/343 in order for the workflow and automated tests to work on Cheyenne - https://github.com/NOAA-EMC/regional_workflow/pull/378 These PRs have been merged and this PR updated with the latest hashes. ## TESTS CONDUCTED: Compiles and workflow is successfully generated on Cheyenne, Hera, and Jet; ran many tests that all passed; reference PR on Github for full list. ## ISSUE: Resolves #57
christinaholtNOAA
referenced
this pull request
in christinaholtNOAA/ufs-srweather-app
Dec 14, 2020
## DESCRIPTION OF CHANGES: Currently master is broken and will not build and/or run on any platform due to incompatible hashes and outdated changes. Several fixes are needed to get master back in working order, most of which will be included in this PR. The direct changes made in ufs-srweather-app for this PR are: - Partially cherry-picking release-branch changes to update build system and documentation - Updating static hashes to the latest versions of `develop` branches for ufs-weather-model, EMC_post, UFS_UTILS, and regional_workflow Some changes that were needed prior to this PR being merged are: - [x] EMC_post needs to be updated to include an updated executable name and flat config files - NOAA-EMC/UPP#237 - [x] regional_workflow needs to be updated for the new ufs-weather-model executable name - https://github.com/NOAA-EMC/regional_workflow/pull/374 - [x] regional_workflow also needs to be updated for changed namelist options in the latest ufs-weather-model develop branch - https://github.com/NOAA-EMC/regional_workflow/pull/377 - [x] regional_workflow also needs to be updated with the commit in https://github.com/NOAA-EMC/regional_workflow/pull/343 in order for the workflow and automated tests to work on Cheyenne - https://github.com/NOAA-EMC/regional_workflow/pull/378 These PRs have been merged and this PR updated with the latest hashes. ## TESTS CONDUCTED: Compiles and workflow is successfully generated on Cheyenne, Hera, and Jet; ran many tests that all passed; reference PR on Github for full list. ## ISSUE: Resolves ufs-community#57
christinaholtNOAA
referenced
this pull request
in christinaholtNOAA/ufs-srweather-app
Dec 14, 2020
## DESCRIPTION OF CHANGES: Currently master is broken and will not build and/or run on any platform due to incompatible hashes and outdated changes. Several fixes are needed to get master back in working order, most of which will be included in this PR. The direct changes made in ufs-srweather-app for this PR are: - Partially cherry-picking release-branch changes to update build system and documentation - Updating static hashes to the latest versions of `develop` branches for ufs-weather-model, EMC_post, UFS_UTILS, and regional_workflow Some changes that were needed prior to this PR being merged are: - [x] EMC_post needs to be updated to include an updated executable name and flat config files - NOAA-EMC/UPP#237 - [x] regional_workflow needs to be updated for the new ufs-weather-model executable name - https://github.com/NOAA-EMC/regional_workflow/pull/374 - [x] regional_workflow also needs to be updated for changed namelist options in the latest ufs-weather-model develop branch - https://github.com/NOAA-EMC/regional_workflow/pull/377 - [x] regional_workflow also needs to be updated with the commit in https://github.com/NOAA-EMC/regional_workflow/pull/343 in order for the workflow and automated tests to work on Cheyenne - https://github.com/NOAA-EMC/regional_workflow/pull/378 These PRs have been merged and this PR updated with the latest hashes. ## TESTS CONDUCTED: Compiles and workflow is successfully generated on Cheyenne, Hera, and Jet; ran many tests that all passed; reference PR on Github for full list. ## ISSUE: Resolves ufs-community#57
christinaholtNOAA
pushed a commit
to christinaholtNOAA/regional_workflow
that referenced
this pull request
May 16, 2022
* Add archive for ensemble data * Fix observer_gsi data path and NWGES data for archiving * Cosmetic changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Part of the effort described in ufs-community/ufs-srweather-app#71 to update the master branch of ufs-srweather-app to a functioning state.
Updates include:
This PR must be merged prior to ufs-community/ufs-srweather-app#71, then that PR updated to point to this PR's hash.
TESTS CONDUCTED:
The following end-to-end tests are now all successful on Hera (/scratch2/BMC/det/kavulich/workdir/update_app_master/expt_dirs/):
The following end-to-end tests were successful on Jet (/mnt/lfs4/HFIP/dtc-hurr/kavulich/workdir/UFS_SRW_PR_71/expt_dirs):
A few tests on Hera and Jet are still failing, but they are known errors and will be fixed at a later date.
Cheyenne tests are failing but this is fixed by #378
ISSUE (optional):
In conjunction with ufs-community/ufs-srweather-app#71, will solve ufs-community/ufs-srweather-app#57, fixing the master branch of ufs-srweather-app so everyone will be happy and nothing will be broken and we will all live happily ever after.