-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update community run script #491
Conversation
-updated directory name -updated executable path -added error message for binarynemsiompiio option -added netcdfpara option
This PR fixes #492 |
@kayeekayee - Have these changes been tested? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some additional mods that couldn't be added in review:
L38 EMC-post -> UPP
L95-97: remove debug comment and extra whitespace
L298 -> LAM add netcdfpara as well
@fossell Yes, this changes has been tested on Cheyenne with Intel compiler for all the netcdf and netcdfpara cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One super minor formatting change
@fossell Do we know if the GFS model output names are the same with the transition to the global workflow for MRW? The current/old MRW release model output filenames are atmfhhh.nc/sfcfhhh.nc.
Good question, I can ask and we can update if needed. This PR can go ahead as-is to expedite release testing. We can update again once more information is gathered. |
@kayeekayee - What is the status on this testing with these final updates? Has it been run through all cases or just confirmed in a single standalone test? |
@fossell I tested 6 cases including netcdfpara with Intel compiler. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I keep finding more things every time I review, but this is the last one, I swear! We can either link the 9.0.1 release or the soon-to-be released 10.0.12, probably the latter
scripts/run_upp
Outdated
inFileName=${modelDataPath}/atmf${fhour}.nc | ||
flxFileName=${modelDataPath}/sfcf${fhour}.nc | ||
fi | ||
elif [ ${model} == "LAM" ]; then | ||
if [ ${inFormat} == "netcdf" ]; then | ||
if [[ ${inFormat} == "netcdf" || ${inFormat} == "netcdfpara" ]]; then | ||
inFileName=${modelDataPath}/dynf${fhour}.nc | ||
flxFileName=${modelDataPath}/dynf${fhour}.nc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to flxFileName=${modelDataPath}/phyf${fhour}.nc
* Enhancements for HWT experiment: 1. Add TAG as part of the log files so control, EnKF, and ensemble forecast have their unique log file name for the same task. 2. Add COMOUT and COMIN in job/scripts to save the standard output files and processed observation files to COM location. The use of observation files in non-var cloud analysis and radar tten also comes from the COM instead of run directory. 3. Change the name of UPP result files. The real UPP grib2 files are natleve, prslev, ififip, testbed. The bgdawp,bgifi, bgrd3d, bgsfc become links to real grib2 files 4. unify production directories for deterministic forecast and ensemble forecast. (enkfrrfs, refs, rrfs): Use &RUN to decide product directory name 5. Turn on radiance data assimilation 6. Update RRFS_A configurations. * remove member ID from data process COMOUT directory. --------- Co-authored-by: ming hu <ming.hu@clogin04.cactus.wcoss2.ncep.noaa.gov> Co-authored-by: ming hu <ming.hu@clogin03.cactus.wcoss2.ncep.noaa.gov>
run_upp script got the following updates:
-updated directory name from EMC_post to UPP
-updated executable path to tests/install/bin
-added error message for binarynemsiompiio option
-added netcdfpara option
Able to run all 6 cases on Cheyenne with Intel option.