Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update community run script #491

Merged
merged 5 commits into from
May 10, 2022
Merged

Conversation

kayeekayee
Copy link
Contributor

run_upp script got the following updates:
-updated directory name from EMC_post to UPP
-updated executable path to tests/install/bin
-added error message for binarynemsiompiio option
-added netcdfpara option

Able to run all 6 cases on Cheyenne with Intel option.

-updated directory name
-updated executable path
-added error message for binarynemsiompiio option
-added netcdfpara option
@fossell
Copy link
Contributor

fossell commented May 5, 2022

This PR fixes #492

@fossell
Copy link
Contributor

fossell commented May 5, 2022

@kayeekayee - Have these changes been tested?

Copy link
Contributor

@hertneky hertneky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional mods that couldn't be added in review:

L38 EMC-post -> UPP
L95-97: remove debug comment and extra whitespace
L298 -> LAM add netcdfpara as well

scripts/run_upp Outdated Show resolved Hide resolved
scripts/run_upp Outdated Show resolved Hide resolved
scripts/run_upp Show resolved Hide resolved
scripts/run_upp Outdated Show resolved Hide resolved
@kayeekayee
Copy link
Contributor Author

kayeekayee commented May 5, 2022

@fossell Yes, this changes has been tested on Cheyenne with Intel compiler for all the netcdf and netcdfpara cases.
Here is the test path: /glade/scratch/kayee/UPP/UFFDA/UFFDA

Copy link
Contributor

@hertneky hertneky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One super minor formatting change

@fossell Do we know if the GFS model output names are the same with the transition to the global workflow for MRW? The current/old MRW release model output filenames are atmfhhh.nc/sfcfhhh.nc.

scripts/run_upp Outdated Show resolved Hide resolved
@fossell
Copy link
Contributor

fossell commented May 5, 2022

@fossell Do we know if the GFS model output names are the same with the transition to the global workflow for MRW? The current/old MRW release model output filenames are atmfhhh.nc/sfcfhhh.nc.

Good question, I can ask and we can update if needed. This PR can go ahead as-is to expedite release testing. We can update again once more information is gathered.

scripts/run_upp Outdated Show resolved Hide resolved
@fossell
Copy link
Contributor

fossell commented May 9, 2022

@kayeekayee - What is the status on this testing with these final updates? Has it been run through all cases or just confirmed in a single standalone test?
@hertneky - Can you review the final updates Ka Yee made in response to your requested changes?

@kayeekayee
Copy link
Contributor Author

@fossell I tested 6 cases including netcdfpara with Intel compiler.

@fossell
Copy link
Contributor

fossell commented May 9, 2022

@fossell I tested 6 cases including netcdfpara with Intel compiler.

Great! Then I think this should be ok to merge. We'll wait for @hertneky to give her final approval on the PR though.

Copy link
Contributor

@hertneky hertneky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I keep finding more things every time I review, but this is the last one, I swear! We can either link the 9.0.1 release or the soon-to-be released 10.0.12, probably the latter

scripts/run_upp Outdated
inFileName=${modelDataPath}/atmf${fhour}.nc
flxFileName=${modelDataPath}/sfcf${fhour}.nc
fi
elif [ ${model} == "LAM" ]; then
if [ ${inFormat} == "netcdf" ]; then
if [[ ${inFormat} == "netcdf" || ${inFormat} == "netcdfpara" ]]; then
inFileName=${modelDataPath}/dynf${fhour}.nc
flxFileName=${modelDataPath}/dynf${fhour}.nc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to flxFileName=${modelDataPath}/phyf${fhour}.nc

scripts/run_upp Show resolved Hide resolved
@fossell fossell merged commit dc53781 into NOAA-EMC:release/public-v3 May 10, 2022
@kayeekayee kayeekayee deleted the run_upp branch May 10, 2022 21:00
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this pull request Oct 18, 2023
* Enhancements for HWT experiment:
1. Add TAG as part of the log files so control, EnKF, and ensemble forecast
   have their unique log file name for the same task.
2. Add COMOUT and COMIN in job/scripts to save the standard output files and processed observation files to COM location.
   The use of observation files in non-var cloud analysis and radar tten also comes from the COM instead of run directory.
3. Change the name of UPP result files. The real UPP grib2 files are natleve, prslev, ififip, testbed.
      The bgdawp,bgifi, bgrd3d, bgsfc become links to real grib2 files
4. unify production directories for deterministic forecast and ensemble forecast.
   (enkfrrfs, refs, rrfs): Use &RUN to decide product directory name
5. Turn on radiance data assimilation
6. Update RRFS_A  configurations.

* remove member ID from data process COMOUT directory.

---------

Co-authored-by: ming hu <ming.hu@clogin04.cactus.wcoss2.ncep.noaa.gov>
Co-authored-by: ming hu <ming.hu@clogin03.cactus.wcoss2.ncep.noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants