Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync develop to dev/ufs-weather-model #957

Conversation

JessicaMeixner-NOAA
Copy link
Collaborator

Pull Request Summary

This syncs the develop branch to dev/ufs-weather-model branch

Description

Three main PRs of note include:

Issue(s) addressed

ufs-community/ufs-weather-model#1668

Commit Message

Sync develop to dev/ufs-wetaher-model

Check list

Testing

  • How were these changes tested? Through UFS hera.intel hera.gnu
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)? No, as these were each run with the other PRs. Can run if decided necessary.
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.) n/a
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
    n/a

DeniseWorthen and others added 5 commits March 14, 2023 15:39
…n. By-pass mpi send/recv set-up in w3initmd when using domain decomposition. (NOAA-EMC#949)
…d approach. (NOAA-EMC#888)


*     Consolidation and performance improvements of wave setup computation on structured and unstructured grids.
*     Performance and memory improvement of the unstructured framework.
*     Introduction of a new limiter (mixture of Hersbach & Janssen + Komen etal.)
*     Alternative computations of the group velocity for unstructured grids
*     Introduce under-relaxation for triads and wave breaking
*     Improve shallow-water source term integration for explicit source terms within the unstructured down-scaling approach.
*     Bug fixes for wetting & drying for both implicit and explicit schemes.
*     Bug fix for the wave triad interaction.
*     Introduce coastline reflection for the implicit scheme, and homogenization within the new wetting & drying scheme.
*     Introduction of Block Explicit Solver as an option for unstructured meshes.
*     Consolidation of the implicit solver in terms of memory usage, coherence.
*     debug output and further work on the Jacobi solver towards CPU coherency of the Jacobi solver.
*     Fix bugs and clean & test 2nd order time-space LAX-FCT-CRD scheme.

Co-authored-by: aliabdolali <ali.abdolali@noaa.gov>
Co-authored-by: Ty Hesser <thesser1@gmail.com>
Copy link
Contributor

@DeniseWorthen DeniseWorthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matches my add_unstr_wise branch, minus the changes for unstructured in the mesh cap itself.

Copy link
Collaborator

@MatthewMasarik-NOAA MatthewMasarik-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code review checks out.

@JessicaMeixner-NOAA has successfully tested both intel / gnu on hera and posted the logs here: ufs-community/ufs-weather-model#1673 (comment).

Approved.

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit df3c1e2 into NOAA-EMC:dev/ufs-weather-model Mar 28, 2023
@JessicaMeixner-NOAA JessicaMeixner-NOAA deleted the sync-dev-ufs-wwise branch December 12, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants