-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync develop to dev/ufs-weather-model #957
Sync develop to dev/ufs-weather-model #957
Conversation
…main decomposition. (NOAA-EMC#943)
…n. By-pass mpi send/recv set-up in w3initmd when using domain decomposition. (NOAA-EMC#949)
…d approach. (NOAA-EMC#888) * Consolidation and performance improvements of wave setup computation on structured and unstructured grids. * Performance and memory improvement of the unstructured framework. * Introduction of a new limiter (mixture of Hersbach & Janssen + Komen etal.) * Alternative computations of the group velocity for unstructured grids * Introduce under-relaxation for triads and wave breaking * Improve shallow-water source term integration for explicit source terms within the unstructured down-scaling approach. * Bug fixes for wetting & drying for both implicit and explicit schemes. * Bug fix for the wave triad interaction. * Introduce coastline reflection for the implicit scheme, and homogenization within the new wetting & drying scheme. * Introduction of Block Explicit Solver as an option for unstructured meshes. * Consolidation of the implicit solver in terms of memory usage, coherence. * debug output and further work on the Jacobi solver towards CPU coherency of the Jacobi solver. * Fix bugs and clean & test 2nd order time-space LAX-FCT-CRD scheme. Co-authored-by: aliabdolali <ali.abdolali@noaa.gov> Co-authored-by: Ty Hesser <thesser1@gmail.com>
Conflicts: model/src/w3wavemd.F90
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
matches my add_unstr_wise branch, minus the changes for unstructured in the mesh cap itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code review checks out.
@JessicaMeixner-NOAA has successfully tested both intel
/ gnu
on hera
and posted the logs here: ufs-community/ufs-weather-model#1673 (comment).
Approved.
Pull Request Summary
This syncs the develop branch to dev/ufs-weather-model branch
Description
Three main PRs of note include:
Issue(s) addressed
ufs-community/ufs-weather-model#1668
Commit Message
Sync develop to dev/ufs-wetaher-model
Check list
Testing
n/a