Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update WW3 with latest develop #1673

Conversation

JessicaMeixner-NOAA
Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA commented Mar 22, 2023

Description

This updates WW3 with it's latest develop branch. The PRs of note include:

This PR is not expected to change answers and was tested with the in-development work of @DeniseWorthen for unstructured grid in coupled cases. This PR can be combined with any PR that is not a change to WW3 if needed.

Top of commit queue on: TBD

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

fixes #1668
WW3 PR: NOAA-EMC/WW3#957

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@JessicaMeixner-NOAA
Copy link
Collaborator Author

@DeniseWorthen
Copy link
Collaborator

@jkbk2004 Please consider prioritizing this PR. Thanks.

@DeniseWorthen DeniseWorthen added the No Baseline Change No Baseline Change label Mar 22, 2023
@github-actions
Copy link

@JessicaMeixner-NOAA please bring these up to date with respective authoritative repositories

  • ufs-weather-model NOT up to date

@jkbk2004
Copy link
Collaborator

@JessicaMeixner-NOAA note this pr is combine with #1633. we started working on.

@JessicaMeixner-NOAA
Copy link
Collaborator Author

@JessicaMeixner-NOAA note this pr is combine with #1633. we started working on.

Thanks for the information. Please let me know if there's anything I need to do from my end. I'll watch for when it'll be time for merging the WW3 PR.

zach1221 pushed a commit that referenced this pull request Mar 28, 2023
… update #1673 (#1633)

* Add 4 new quilting restart tests

* Remove tests/qr.conf

* Fix fv3_conf/regional_run.IN script to correctly copy restart files from dependent directory

* Clean up Thompson table files (#38)

* update control_qr_p8 control_restart_qr_p8

* Disable cpld_control_ciceC_p8 and cpld_control_c192_p8/cpld_restart_c192_p8 on Gaea

* Update FV3 and WW3

Co-authored-by: Dusan Jovic <Dusan.Jovic@noaa.gov>
Co-authored-by: Jessica Meixner <Jessica.Meixner@noaa.gov>
@jkbk2004
Copy link
Collaborator

merged in with #1633

@jkbk2004 jkbk2004 closed this Mar 28, 2023
@JessicaMeixner-NOAA JessicaMeixner-NOAA deleted the syncWW3wwise branch April 19, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync with latest WW3 develop
3 participants