Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLM Lake Model and update Flake #606

Merged
merged 95 commits into from
Apr 26, 2023

Conversation

SamuelTrahanNOAA
Copy link
Contributor

@SamuelTrahanNOAA SamuelTrahanNOAA commented Dec 1, 2022

Description

This PR adds the CLM Lake Model, updates the Flake This PR adds the CLM Lake Model, updates the Flake model, and adds an experimental feature to run both NSST and a lake model on lake points. The FV3_HRRR suite uses clm_lake by default, and the long-forgotten control_flake test now exists. Any test with LKM=1 that validates a restart file will change results.

Issue(s) addressed

ufs-community/ufs-weather-model#1510

Testing

How were these changes tested? Manual review of output, and running regression tests.
What compilers / HPCs was it tested with? hera.intel and hera.gnu
Are the changes covered by regression tests? several tests are updated and a few new ones are added
Have the ufs-weather-model regression test been run? On what platform? hera.intel and hera.gnu

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below. Any tests with LKM=1
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

ufs-community/ccpp-physics#26 to add the CLM Lake Model

YihuaWu-NOAA and others added 30 commits August 8, 2022 14:14
@SamuelTrahanNOAA
Copy link
Contributor Author

This is scheduled for commit today, but it hasn't been reviewed.

@grantfirl
Copy link
Collaborator

@SamuelTrahanNOAA ufs-community/ccpp-physics#26 is merged so you can update this branch in prep for its merge.

@jkbk2004
Copy link
Collaborator

@DusanJovic-NOAA @junwang-noaa @BrianCurtis-NOAA we can merge in this pr with final approvals.

@junwang-noaa
Copy link
Collaborator

@SamuelTrahanNOAA Now we are in the transition to move the restart file writing to write grid component. I saw you made changes in FV3GFS_io.F90, corresponding changes need to go to FV3GFS_restart_io.F90 so that the write grid comp restart file writing feature can be maintained. I think you can do that in a PR after this, is that OK? Thanks

@SamuelTrahanNOAA
Copy link
Contributor Author

corresponding changes need to go to FV3GFS_restart_io.F90

Yes, definitely. The smoke and dust restart logic isn't in there either. We'd need alternative tests for the hrrr_control and rrfs_smoke_conus13km_hrrr_warm that use the grid component to write the restart. Can you tell me how to enable that feature?

@junwang-noaa
Copy link
Collaborator

You can set "quilting_restart: .true." in the model_configure.

@jkbk2004 jkbk2004 merged commit 33ac26d into NOAA-EMC:develop Apr 26, 2023
This was referenced Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants