Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLM Lake Model and update Flake #606

Merged
merged 95 commits into from
Apr 26, 2023
Merged
Show file tree
Hide file tree
Changes from 93 commits
Commits
Show all changes
95 commits
Select commit Hold shift + click to select a range
704174e
Updated flake physics and modified related files
YihuaWu-NOAA Aug 8, 2022
fe17599
Merge branch 'flake.v9' into flake
HelinWei-NOAA Aug 10, 2022
8b4f476
update ccpp-physics repo
HelinWei-NOAA Aug 10, 2022
9ca4b39
update ccpp-physics repo
HelinWei-NOAA Aug 10, 2022
a37d41b
Merge branch 'flake' of github.com:HelinWei-NOAA/fv3atm into flake
HelinWei-NOAA Aug 10, 2022
ee532c4
add clm lake
SamuelTrahanNOAA Aug 11, 2022
9486b54
point to Sam's repo
SamuelTrahanNOAA Aug 11, 2022
f8e6405
bug fixes, clm lake restart, and clm lake suite
SamuelTrahanNOAA Aug 16, 2022
2ddec59
bug fixes for gfortran and "all suites" build
SamuelTrahanNOAA Aug 18, 2022
69a63f3
various snow bug fixes
SamuelTrahanNOAA Aug 25, 2022
647496c
rainnc and rainc do not exist
SamuelTrahanNOAA Aug 25, 2022
f3dd187
remove bad unit conversion
SamuelTrahanNOAA Aug 25, 2022
29473b6
remove bad unit conversion
SamuelTrahanNOAA Aug 25, 2022
a73b636
Merge branch 'clm_lake_develop.v9' of ssh://github.com/SamuelTrahanNO…
SamuelTrahanNOAA Aug 25, 2022
23ff88b
unit conversion issue
SamuelTrahanNOAA Aug 25, 2022
9bb0626
LAKEDEBUG is now clm_lake_debug namelist parameter
SamuelTrahanNOAA Aug 25, 2022
b96563c
tweaks for salty lakes
SamuelTrahanNOAA Aug 26, 2022
32dabe1
fix bugs in salty code and add Caspian & Dead seas
SamuelTrahanNOAA Aug 26, 2022
6fdf62e
clm lake restart in sfc files; fix some bugs, and make some bugs
SamuelTrahanNOAA Sep 16, 2022
cbcd70a
set roughness length over ice & water in clm lake model
SamuelTrahanNOAA Sep 19, 2022
7b9486b
several fixes to initialization
SamuelTrahanNOAA Oct 11, 2022
342c0a7
unneeded commit to satisfy git's eccentricites
SamuelTrahanNOAA Oct 11, 2022
58da3a8
Merge remote-tracking branch 'sam/iterative_changes_clm_lake.v9' into…
SamuelTrahanNOAA Oct 11, 2022
b255fa8
more updates from tanya
SamuelTrahanNOAA Oct 17, 2022
4d41faa
more updates from tanya
SamuelTrahanNOAA Oct 17, 2022
e6b139e
rework lake variables and add fractional ice
SamuelTrahanNOAA Oct 20, 2022
6098130
FV3_HRRR_clm_lake suite
SamuelTrahanNOAA Oct 20, 2022
aec7413
bug fixes to get fractional ice working
SamuelTrahanNOAA Oct 20, 2022
b558b8c
bug fixes for restart (not enough though)
SamuelTrahanNOAA Oct 24, 2022
45853f5
merge develop
SamuelTrahanNOAA Nov 21, 2022
faaf445
merge develop
SamuelTrahanNOAA Nov 21, 2022
bae1630
correct space-padding and remove changes that broke stuff
SamuelTrahanNOAA Nov 23, 2022
c9b2f47
revert some changes
SamuelTrahanNOAA Nov 28, 2022
dcb4317
remove unused code
SamuelTrahanNOAA Nov 28, 2022
dfa2a55
move a variable up to module level
SamuelTrahanNOAA Nov 28, 2022
8701b84
revert changes in ccpp physics
SamuelTrahanNOAA Nov 28, 2022
ff7a291
remove flake changes
SamuelTrahanNOAA Nov 28, 2022
4d5df7b
remove flake variables
SamuelTrahanNOAA Nov 28, 2022
df1e091
put clm lake restart vars back in
SamuelTrahanNOAA Nov 28, 2022
53e145b
put some changes back in
SamuelTrahanNOAA Nov 29, 2022
5693728
put new flake back in
SamuelTrahanNOAA Nov 30, 2022
98630da
Need larger DIAG_SIZE for clm lake model
SamuelTrahanNOAA Nov 30, 2022
8ab7e21
renamed variables
SamuelTrahanNOAA Dec 1, 2022
1199438
merge upstream develop
SamuelTrahanNOAA Dec 5, 2022
aed4489
bug fix: fill restart input with prior values
SamuelTrahanNOAA Mar 1, 2023
b907a59
correction to a comment in clm_lake.f90
SamuelTrahanNOAA Mar 1, 2023
c205d94
restart works with FV3_HRRR suite
SamuelTrahanNOAA Mar 2, 2023
c3b9807
do not freeze great salt lakes
SamuelTrahanNOAA Mar 2, 2023
14b16b6
address reviewer comments
SamuelTrahanNOAA Mar 2, 2023
d00e98b
comment in clm_lake.f90 to resolve reviewer confusion
SamuelTrahanNOAA Mar 2, 2023
1a9c120
merge upstream develop
SamuelTrahanNOAA Mar 2, 2023
cdf8653
change missed in merge
SamuelTrahanNOAA Mar 2, 2023
ed6f862
CLM Lake is the default
SamuelTrahanNOAA Mar 2, 2023
a74281e
incorrect active= for two variables
SamuelTrahanNOAA Mar 2, 2023
37f09da
remove clm_lake_fill_with_zero
SamuelTrahanNOAA Mar 2, 2023
376f635
coare changes and bug fixes from tanya
SamuelTrahanNOAA Mar 2, 2023
45c9a8e
further updates from tanya
SamuelTrahanNOAA Mar 2, 2023
ec1f18d
disable wordy warning without LAKEDEBUG
SamuelTrahanNOAA Mar 2, 2023
0eb233d
update from tanya review
SamuelTrahanNOAA Mar 2, 2023
363625e
FV3_HRRR uses clm lake; new FV3_HRRR_flake for flake
SamuelTrahanNOAA Mar 2, 2023
14d0625
FV3_RAP_clm_lake suite
SamuelTrahanNOAA Mar 2, 2023
14897ec
FV3_RAP_clm_lake suite
SamuelTrahanNOAA Mar 2, 2023
2913a54
FV3_RAP_clm_lake suite correctly
SamuelTrahanNOAA Mar 2, 2023
6bf5138
use 64 bits for lake and disable broken coare code
SamuelTrahanNOAA Mar 3, 2023
d57b67a
Eliminate an out-of-bounds access in MDLFLD.f in UPP. This UPP bug is…
SamuelTrahanNOAA Mar 3, 2023
3e31be3
UPP: update author changelog
SamuelTrahanNOAA Mar 3, 2023
46e8ad7
merge clm_lake_merge_upstream
SamuelTrahanNOAA Mar 3, 2023
9c44530
Merge remote-tracking branch 'sam/clm_lake_merge_upstream' into clm_l…
SamuelTrahanNOAA Mar 3, 2023
d9da6fb
point to upp develop now that bug is fixed
SamuelTrahanNOAA Mar 3, 2023
51d315a
clm lake bug fixes in ccpp/physics
SamuelTrahanNOAA Mar 9, 2023
70e8cc6
more diagnostic output to track down threading issue
SamuelTrahanNOAA Mar 9, 2023
ee37732
flake bug fixes so restart does not crash
SamuelTrahanNOAA Mar 9, 2023
1fd1427
missing active= lines
SamuelTrahanNOAA Mar 9, 2023
3c6d491
bug fix from @tanyasmirnova for rrfs crashes during restart
SamuelTrahanNOAA Mar 17, 2023
9abd598
merge restart fix from tanya
SamuelTrahanNOAA Mar 17, 2023
bfc7f1b
merge ufs/dev into ccpp/physics
SamuelTrahanNOAA Apr 3, 2023
00ea61c
merge develop
SamuelTrahanNOAA Apr 3, 2023
efd5926
clm lake is HRRR default, alternative suite with flake
SamuelTrahanNOAA Apr 4, 2023
8f2b0e9
update ccpp-physics hash
SamuelTrahanNOAA Apr 4, 2023
a2d5a9a
many errors in merge
SamuelTrahanNOAA Apr 4, 2023
8d7ad74
merge fixes from other branch
SamuelTrahanNOAA Apr 4, 2023
5f46d40
get it to compile and run
SamuelTrahanNOAA Apr 4, 2023
ab1c36e
bug fix for 2threads support in conus13km tests
SamuelTrahanNOAA Apr 11, 2023
860d4ed
merge upstream develop
SamuelTrahanNOAA Apr 11, 2023
dda3468
Merge remote-tracking branch 'upstream/develop' into clm_lake_revert.v9
SamuelTrahanNOAA Apr 14, 2023
cf2c7b9
update ccpp-physics hash
SamuelTrahanNOAA Apr 14, 2023
994d373
remove test code from clm_lake.f90
SamuelTrahanNOAA Apr 14, 2023
a020d1b
merge upstream develop
SamuelTrahanNOAA Apr 18, 2023
9152d2c
ccpp/physics: remove repeated constants and redundant variable
SamuelTrahanNOAA Apr 18, 2023
953bbf6
Merge branch 'clm_lake_revert.v9' of ssh://github.com/SamuelTrahanNOA…
SamuelTrahanNOAA Apr 19, 2023
d632210
remove redundant .not.have_2m in sfc_diag.f
SamuelTrahanNOAA Apr 19, 2023
b82a38b
explain why kind_lake exists
SamuelTrahanNOAA Apr 19, 2023
5d0281d
merge develop
SamuelTrahanNOAA Apr 20, 2023
9a48191
point ccpp/physics to upstream ufs/dev
SamuelTrahanNOAA Apr 26, 2023
04dfd91
remove unintentional blank line
SamuelTrahanNOAA Apr 26, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
branch = main
[submodule "ccpp/physics"]
path = ccpp/physics
url = https://github.com/ufs-community/ccpp-physics
branch = ufs/dev
url = https://github.com/SamuelTrahanNOAA/ccpp-physics
branch = clm_lake_revert.v9
[submodule "upp"]
path = upp
url = https://github.com/NOAA-EMC/UPP
Expand Down
1 change: 1 addition & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ add_library(fv3atm
cpl/module_block_data.F90
cpl/module_cplfields.F90
cpl/module_cap_cpl.F90
io/clm_lake_io.F90
io/FV3GFS_io.F90
io/FV3GFS_restart_io.F90
io/module_write_netcdf.F90
Expand Down
2 changes: 2 additions & 0 deletions ccpp/config/ccpp_prebuild_config.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@

DusanJovic-NOAA marked this conversation as resolved.
Show resolved Hide resolved
#!/usr/bin/env python

# CCPP prebuild config for GFDL Finite-Volume Cubed-Sphere Model (FV3)
Expand Down Expand Up @@ -183,6 +184,7 @@
'physics/physics/lsm_noah.f',
'physics/physics/noahmpdrv.F90',
'physics/physics/flake_driver.F90',
'physics/physics/clm_lake.f90',
'physics/physics/sfc_nst_pre.f',
'physics/physics/sfc_nst.f',
'physics/physics/sfc_nst_post.f',
Expand Down
3 changes: 0 additions & 3 deletions ccpp/data/CCPP_typedefs.F90
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,6 @@ module CCPP_typedefs
integer, pointer :: idxday(:) => null() !<
logical, pointer :: icy(:) => null() !<
logical, pointer :: lake(:) => null() !<
logical, pointer :: use_flake(:) => null() !<
logical, pointer :: ocean(:) => null() !<
integer :: ipr !<
integer, pointer :: islmsk(:) => null() !<
Expand Down Expand Up @@ -647,7 +646,6 @@ subroutine gfs_interstitial_create (Interstitial, IM, Model)
allocate (Interstitial%idxday (IM))
allocate (Interstitial%icy (IM))
allocate (Interstitial%lake (IM))
allocate (Interstitial%use_flake (IM))
allocate (Interstitial%ocean (IM))
allocate (Interstitial%islmsk (IM))
allocate (Interstitial%islmsk_cice (IM))
Expand Down Expand Up @@ -1327,7 +1325,6 @@ subroutine gfs_interstitial_phys_reset (Interstitial, Model)
Interstitial%dry = .false.
Interstitial%icy = .false.
Interstitial%lake = .false.
Interstitial%use_flake = .false.
Interstitial%ocean = .false.
Interstitial%islmsk = 0
Interstitial%islmsk_cice = 0
Expand Down
6 changes: 0 additions & 6 deletions ccpp/data/CCPP_typedefs.meta
Original file line number Diff line number Diff line change
Expand Up @@ -1238,12 +1238,6 @@
units = flag
dimensions = (horizontal_loop_extent)
type = logical
[use_flake]
standard_name = flag_for_using_flake
long_name = flag indicating lake points using flake model
units = flag
dimensions = (horizontal_loop_extent)
type = logical
[ocean]
standard_name = flag_nonzero_ocean_surface_fraction
long_name = flag indicating presence of some ocean surface area fraction
Expand Down
266 changes: 250 additions & 16 deletions ccpp/data/GFS_typedefs.F90

Large diffs are not rendered by default.

Loading