-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Community Convective Cloud (C3) scheme #657
Conversation
@haiqinli I wonder if we should create a suite def file also for the RRFS configuration with C3? I made 2 for the global only (GFSv17 and GFSv17 coupled) |
@lisa-bengtsson Yes, I will add a HRRR_c3 suite for RRFS when I update this PR. |
This needs to be reviewed before it can get into UFSWM commit queue. |
@haiqinli @BrianCurtis-NOAA This PR also appears to depend on a CCPP changes but no information is provided here or at the UFS PR. Is there a CCPP PR associated with this ? |
@DeniseWorthen Yes, the associated CCPP PR is ufs-community/ccpp-physics#73. Thanks. |
@haiqinli Please link that PR to this PR. Do that by editing your PR description with "- depends on" and the link to the CCPP PR. In the above PR information you answered "no" to the question of whether this PR has dependencies. |
@DeniseWorthen The PR description has been updated accordingly. Thanks. |
@haiqinli The physics PR was merged. Please revert .gitmodules and update the ccpp/physics submodule pointer in preparation for the fv3atm merge. |
@haiqinli ccpp pr was merged. Can you update ccpp/physics submodule pointer and revert change in gitmodules? Correct hash is ufs-community/ccpp-physics@427c77b |
@haiqinli can you resolve the conversation as well? |
@jkbk2004 @grantfirl Yes, I am working on it, and will update when it is done. |
I have some difficulties to do git push right now, and will continue to try it. [Haiqin.Li@hfe04 fv3atm]$ git push https://github.com/haiqinli/fv3atm.git |
@jkbk2004 @grantfirl Revert submodule pointer to ufs-community/ccpp-physics@427c77b is done. Thanks. |
Description
Testing
How were these changes tested? Yes
What compilers / HPCs was it tested with? Intel compiler on Hera
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
A new regression test run case of C3 convection should be added.
Have the ufs-weather-model regression test been run? On what platform? Yes, on Hera with Intel compiler.
Dependencies
Do PRs in upstream repositories need to be merged first? Yes.