-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Community Convective Cloud (C3) scheme #73
Conversation
haiqinli
commented
May 23, 2023
- Name the new unified convective parameterization as "Community Convective Cloud (c3) parameterization";
- Update the aerosol-aware for GF;
- Merge the aerosol-aware and RRFS configuration from GF into C3;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Just a few small comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, @haiqinli .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
@dustinswales Since you requested changes, please re-review and approve if your comments were adequately addressed. |
@haiqinli Please pull down the top of the ufs/dev branch and merge it into this branch. Afterward, do the same for fv3atm and ufs-weather-model. When you do fv3atm, be sure to do |
@grantfirl Thank you very much for your suggestions. I have synced the ccpp/physics, fv3atm, and ufs-weather-model accordingly. I am redoing a regression test, and will update when it is done. |
All tests ran ok on ufs-community/ufs-weather-model#1795. @grantfirl @dustinswales can you go ahead to merge in this pr? |