Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes #8

Merged
merged 12 commits into from
Nov 15, 2019
Merged

Bugfixes #8

merged 12 commits into from
Nov 15, 2019

Conversation

junwang-noaa
Copy link
Collaborator

This pull request has several code changes:

  1. vlab #69814: post fixes for mismatched field name, computinge level 1 alpint, computing cwm for gfdlmp and initialized ihrst.
  2. vlab #69735, update netcdf time units attribute when iau_offset on write grid component
  3. ufs issue Add 3D reflectivity to restart file #4 , Add 3D reflectivity to restart file and fix the restart reproducibility for regional fv3,
  4. ufs issue land mask and tsfco issue when cplflx=true #5 , resolve land mask and tsfco issue when cplflx=true
  5. ufs issue Update in scale-aware TKE-based moist eddy-diffusion mass-flux scheme satmedmfvdifq #6 , Update in scale-aware TKE-based moist eddy-diffusion mass-flux scheme satmedmfvdifq
  6. ufs issue fixes in gfdl_cloud_microphys.F90 to reduce the cold bias in lower atmosphere layer #7 , fixes in gfdl_cloud_microphys.F90 to reduce the cold bias in lower atmosphere layer

Related PR:
NOAA-EMC/GFDL_atmos_cubed_sphere#8
NCAR/ccpp-physics#351

This was referenced Nov 11, 2019
Merged
Merged
JessicaMeixner-NOAA
JessicaMeixner-NOAA approved these changes Nov 12, 2019
View reviewed changes
Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bugfixes for ufs issue #5 (resolve land mask and tsfco issue when cplflx=true) code is here.

The .gitmodules are pointing to your forks for ccpp and GFDL_atmos_cubed_sphere but I'm assuming those will be updated before this PR actually goes in?

ericaligo-NOAA
ericaligo-NOAA approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@ericaligo-NOAA ericaligo-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good.

@junwang-noaa
Copy link
Collaborator Author

Jessica,

Yes, once we have the pull request approved and the RT passed, we will update the submodules.

jswhit2
jswhit2 reviewed Nov 12, 2019
View reviewed changes
io/module_wrt_grid_comp.F90
! if (lprnt) write(0,*) 'in wrt initial, io_baseline time=',idate,'rc=',rc
idate(7) = 1
wrt_int_state%idate = idate
wrt_int_state%fdate = idate
Copy link
Collaborator

@jswhit2 jswhit2 Nov 12, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment here since it's not obvious what's going on. Something like "update idate when IAU is enabled to reference center of IAU window"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments "! update IO-BASETIME and idate on write grid comp when IAU is enabled"

jswhit2
jswhit2 reviewed Nov 12, 2019
View reviewed changes
io/module_wrt_grid_comp.F90 Outdated
@@ -867,6 +891,17 @@ subroutine wrt_initialize(wrt_comp, imp_state_write, exp_state_write, clock, rc)

if (ESMF_LogFoundError(rcToCheck=rc, msg=ESMF_LOGERR_PASSTHRU, line=__LINE__, file=__FILE__)) return

! add iau here
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more informative comment please

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comments "! update the time:units when idate on write grid component is changed"

jswhit2
jswhit2 reviewed Nov 12, 2019
View reviewed changes
io/module_wrt_grid_comp.F90 Outdated
@@ -1251,9 +1264,10 @@ subroutine wrt_run(wrt_comp, imp_state_write, exp_state_write,clock,rc)
!
nf_seconds = nf_hours*3600+nf_minuteS*60+nseconds+real(nseconds_num)/real(nseconds_den)
! shift forecast hour by iau_offset if iau is on.
nf_seconds = nf_seconds - iau_offset*3600
!nf_seconds = nf_seconds - iau_offset*3600
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can delete this commented out line

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

jswhit2
jswhit2 approved these changes Nov 12, 2019
View reviewed changes
Copy link
Collaborator

@jswhit2 jswhit2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with IAU and netcdf output and time units attribute is written correctly.

JongilHan66
JongilHan66 reviewed Nov 13, 2019
View reviewed changes
Copy link
Contributor

@JongilHan66 JongilHan66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes for satmedmfvdifq look fine.

@climbfuji climbfuji mentioned this pull request Nov 14, 2019
Merged
@junwang-noaa junwang-noaa merged commit b18739d into NOAA-EMC:develop Nov 15, 2019
junwang-noaa added a commit that referenced this pull request Nov 15, 2019
@junwang-noaa
update submodules atmos_cubed_sphere and ccpp/physics for fv3atm #8
5bfd3c6
@climbfuji climbfuji mentioned this pull request Nov 18, 2019
Closed
@junwang-noaa junwang-noaa deleted the bugfixes branch December 9, 2019 16:51
@junwang-noaa junwang-noaa mentioned this pull request Dec 17, 2019
Closed
XiaqiongZhou-NOAA pushed a commit to XiaqiongZhou-NOAA/fv3atm that referenced this pull request Sep 22, 2022
@JiliDong-NOAA
Merge pull request NOAA-EMC#8 from JiliDong-NOAA/develop
c5e2354 
CCPP/physics v6 documentation updates + empty CCPP phase subroutine c…
LarissaReames-NOAA pushed a commit to LarissaReames-NOAA/fv3atm that referenced this pull request Nov 17, 2023
@DusanJovic-NOAA
Merge pull request NOAA-EMC#8 from junwang-noaa/regfv3_rst
452333a 
restart reproducibility fix for regional fv3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JongilHan66 JongilHan66 JongilHan66 left review comments

@ericaligo-NOAA ericaligo-NOAA ericaligo-NOAA approved these changes

@RuiyuSun RuiyuSun RuiyuSun approved these changes

@JessicaMeixner-NOAA JessicaMeixner-NOAA JessicaMeixner-NOAA approved these changes

@jswhit2 jswhit2 jswhit2 approved these changes

@DusanJovic-NOAA DusanJovic-NOAA Awaiting requested review from DusanJovic-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@junwang-noaa @jswhit2 @JessicaMeixner-NOAA @RuiyuSun @JongilHan66 @ericaligo-NOAA