forked from NOAA-EMC/fv3atm
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/statediagnose #5
Closed
DeniseWorthen
wants to merge
142
commits into
junwang-noaa:fv3_cmepsIC
from
DeniseWorthen:feature/statediagnose
Closed
Feature/statediagnose #5
DeniseWorthen
wants to merge
142
commits into
junwang-noaa:fv3_cmepsIC
from
DeniseWorthen:feature/statediagnose
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cplwav2atm flag for coupling wave to atm
merge to latest develop
The HAFS related developments for the write_grid_component (#10)
change ifmin to zero at fh00 for inline POST (#14)
merge to latest develop
…from the suites as this is included in GFS_surface_composites_inter_run
Update EMC dev/emc from NCAR dtc/develop 2019/12/17 (NOAA-EMC#30)
… reading fractional grid orography file and run as no fractional grid, and minor bug fix in physics driver related to the fractional grid - FV3GFS_io.F90 is modified to use lake fraction if it exists to distinguish lake from ocean
GFSv16 netcdf post ficein cpl (NOAA-EMC#48)
…A-EMC#145) * atmos_model.F90: remove dependency of stochastic physics on IPD_Control * Add mpi_wrapper to stochastic_physics to substitute calls to fv_mp_mod routines * Make cellular automata code independent of fv_mp_mod * Make cellular automata code independent of atmosphere_mod * Add halo exchange routine to stochastic_physics code * Remove dependency on GFS_coupling_type from stochastic_physics.F90 * Remove dependency on GFS_grid_type in stochastic_physics and stochastic_physics_sfc * Cleanup work, avoid unnecessary data copies * Move stochastic physics code into its own wrapper/driver * Remove dependency on Statein, Coupling and Intdiag DDT from cellular_automata_sgs.F90 * Compile kinddef module, cleanup stochastic_physics_wrapper.F90 * Update cmake build system * Fix a bug in atmos_model.F90, inadvertetly removed a closing parenthesis * Update to build system for stochastic_physics_wrapper following cmake updates * Update gnumake build to include stochastic_physics wrapper * Remove commented out lines from stochastic_physics/makefile Co-authored-by: Jun Wang <jun.wang@noaa.gov>
* Add infrastructure to FV3 for recent RRTMGP improvements in ccpp-physics * Move allocate statements * Updated ccpp-physics * Updated physics. Some changes on FV3 side to handle physics changes. * Updated .gitmodules * Revert change to .gitmodules and update submodule pointer for ccpp-physics Co-authored-by: Dom Heinzeller <climbfuji@ymail.com>
NOAA-EMC#155) Fixes several bugs in several physics schemes. Adds update to the two-way WW3 atmosphere coupling. Save surface roughness over water, ice and land in three separate variables so that restarts can be reproducible, even for the fractional grid case. Makes uncoupled standalone GFS work with fractional grid. Co-authored-by: Jessica.Meixner <Jessica.Meixner@noaa.gov> Co-authored-by: Dom Heinzeller <climbfuji@ymail.com> Co-authored-by: Jun.Wang <Jun.Wang@noaa.gov>
through same SR
* Diagnostic 3D instantaneous cloud fractions added. * Bug fix for reflectivity in restart files. * Update to GFS_restart.F90 to include if block to test for reflectivity flag.
* add esmf810 VMEpoch change and iau restart timing change
* update to pre-existing land perts scheme, ready for addition of the new scheme * updates to land perts scheme, so that namelist input and control_type variables are in generic (i.e., variable agnostic) arrays * minor bug fix GFS_typedefs.meta * Phil's ccpp changes * minor bug fix * Lndp updates, including moving around the calling structure. * lndp clean-up * lndp submodule clean-up * Updated submodules for merge. * Fixed typo in vegfrac name * deleted GFS_land_perts.F90 (moved to stochastic_physics) * Removing FV3 dependency from stochastic_physics, and into wrapper * Fix linker problem in gfsphysics/CMakeLists.txt by removing physics/physparam.f from IPD sources * edits to compile with gnumake * Revert change to .gitmodules for ccpp-physics and update submodule pointer for ccpp-physics Co-authored-by: Dom Heinzeller <climbfuji@ymail.com>
This PR removes dependency information from the CCPP prebuild config. See NCAR/ccpp-framework#308 and NCAR/ccpp-framework#317 for details on the motivation for this change and the actual implementation. It also removes some legacy code used by the dynamic CCPP build in the past. This PR also contains the changes in NOAA-EMC#156, i.e. the completion of adding the active attribute to GFS_typedefs.F90. On top of this PR, the missing active attribute for phy_fctd is added. Additionally, gfortran-10 compiler flags are added to CCPP's CMakeLists.txt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch includes changes to add a state_diagnose function to FV3 cap. It is controlled by dbug_flag in the nems.configure ALLCOMP_attributes.
I've renamed the "Dump_cplfields" to be "diagnose_cplfields". If dbug>0 then state_diagnose will print the min,max and sum of each state variable on each PET. If DumpFields = true, the netcdf files with the import and export fields will be written. Both state_diagnose and DumpFields can be active.
This shows the output from state_diagnose:
There is a non-fatal error on write component PEs which I haven't been able to fix: