Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[production/RRFS.v1] Parallel IO enhancements from GDIT #818

Merged

Conversation

MatthewPyle-NOAA
Copy link
Collaborator

@MatthewPyle-NOAA MatthewPyle-NOAA commented Apr 4, 2024

Description

Provides the changes needed to take advantage of FMS parallel IO changes. Changes courtesy of Dan Kokron of GDIT. Will be paired with changes in atmos_cubed_sphere

Should be zero-diff changes.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

  • fixes #<issue_number>
  • fixes noaa-emc/fv3atm/issues/<issue_number>

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

  • waiting on noaa-emc/nems/pull/<pr_number>
  • waiting on noaa-emc/fv3atm/pull/<pr_number>

@DusanJovic-NOAA DusanJovic-NOAA changed the title [production/RRFS.v1] parallel IO enhancements from GDIT [production/RRFS.v1] Parallel IO enhancements from GDIT Apr 5, 2024
@MatthewPyle-NOAA MatthewPyle-NOAA marked this pull request as ready for review April 22, 2024 17:16
@jkbk2004
Copy link
Collaborator

jkbk2004 commented May 3, 2024

@MatthewPyle-NOAA This pr can be merged with hash update and reverting changes in gitmodules. Correct hash is NOAA-EMC/GFDL_atmos_cubed_sphere@84c3028

@MatthewPyle-NOAA MatthewPyle-NOAA merged commit ec0ae9e into NOAA-EMC:production/RRFS.v1 May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants