Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[production/RRFS.v1] parallel IO enhancements from GDIT #2226

Conversation

MatthewPyle-NOAA
Copy link
Collaborator

@MatthewPyle-NOAA MatthewPyle-NOAA commented Apr 4, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

Provides a set of changes changes needed to take advantage of FMS parallel IO changes. Changes courtesy of Dan Kokron of GDIT. This umbrella PR includes changes both at the fv3atm and atmos_cubed_sphere levels.

Commit Message:

* UFSWM - 
  * FV3 - 
    * atmos_cubed_sphere - 

Priority:

  • Critical Bugfix: Reason
  • High: Needed for testing in the RRFSv1 release
  • Normal

Git Tracking

UFSWM:

  • Closes #
  • None

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • Required
    • Library names w/versions:
    • Git Stack Issue (JCSDA/spack-stack#)
  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@MatthewPyle-NOAA MatthewPyle-NOAA changed the title [production/RRFS.v1] parallel IO enhancements from GDIT DRAFT: [production/RRFS.v1] parallel IO enhancements from GDIT Apr 8, 2024
@MatthewPyle-NOAA MatthewPyle-NOAA marked this pull request as ready for review April 22, 2024 17:16
@MatthewPyle-NOAA MatthewPyle-NOAA changed the title DRAFT: [production/RRFS.v1] parallel IO enhancements from GDIT [production/RRFS.v1] parallel IO enhancements from GDIT Apr 22, 2024
@jkbk2004
Copy link
Collaborator

jkbk2004 commented May 3, 2024

@MatthewPyle-NOAA Should we start testing this pr?

@MatthewPyle-NOAA
Copy link
Collaborator Author

@jkbk2004 Yes, but wondering if we could combine it with #2249 to resolve both production/RRFS.v1 PRs. But happy to keep them separate if that is easier.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented May 3, 2024

@jkbk2004 Yes, but wondering if we could combine it with #2249 to resolve both production/RRFS.v1 PRs. But happy to keep them separate if that is easier.

It might be easier to go separately. I will start testing this pr on hera/hercules.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented May 3, 2024

@MatthewPyle-NOAA we can start merging sub-component PRs.

@MatthewPyle-NOAA
Copy link
Collaborator Author

Thanks @jkbk2004 - remind me, start with atmos_cubed_sphere and work up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants