Make consistent use of restart_interval across UFS applications
#1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
aerorahul
added
the
CI-Hera-Ready
emcbot
added
CI-Hera-Building
|
Automated global-workflow Testing Results: |
emcbot
added
CI-Hera-Failed
|
Automated global-workflow Testing Results: |
aerorahul
added
CI-Hera-Ready
emcbot
added
CI-Hera-Building
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
emcbot
added
CI-Hera-Failed
emcbot
added
the
CI-Hera-Running
|
Checkout: FAILED |
|
Checkout: FAILED |
emcbot
added
CI-Orion-Running
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
|
Checkout: FAILED |
|
Automated global-workflow Testing Results: |
|
Checkout: FAILED |
emcbot
added
CI-Hera-Passed
|
Checkout: FAILED |
emcbot
added
CI-Orion-Failed
|
Automated global-workflow Testing Results: |
|
The error from the failed Orion vrfy job is: I thought we fixed this issue? @WalterKolczynski-NOAA |
There was a problem hiding this comment.
It looks like the only changes here are for the shellnorm checks, is that correct or am I missing something?
There was a problem hiding this comment.
mostly yes.
Except lines 78-82
There was a problem hiding this comment.
It looks like the only changes here are for the shellnorm checks, is that correct or am I missing something?
| if [[ "${DOIAU}" == "YES" ]]; then | ||
| export restart_interval="3 6" | ||
| export restart_interval="3" | ||
| else |
There was a problem hiding this comment.
I thought the IAU only rewinded (T - 0.5*DA window)? Further, why this change? This is confusing.
There was a problem hiding this comment.
restart_interval = 3 will write restarts every 3 hours.
restart_interval = "3 6" will write restarts at hours 3 and 6 only.
This change is necessary to address the issue this PR is resolving.
There was a problem hiding this comment.
Ah, OK got it. Sorry, this wasn't obvious to me. Thank you!
There was a problem hiding this comment.
Looks like only shellnorm and whitespace corrections.
There was a problem hiding this comment.
shellnorm only corrections.
There was a problem hiding this comment.
yes. And removing all data atm cases.
HenryRWinterbottom
approved these changes
Jun 26, 2023
WalterKolczynski-NOAA
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Restart of model components in the ufs-weather-model is controlled in
model_configureforFV3andnems.configureforMOM6,CICE6andCMEPS.WW3uses an equivalent input asnems.configureto determine its stride.Relevant variables controlling the output frequency of restarts:
nems.configure : restart_nexpected value:
frequency: everyfrequencyunit (unit is controlled via a different variable innems.configure).model_configure : restart_intervalexpected values are:
0: end of the forecastfrequency -1: everyfrequencyhourrestart_hour1 restart_hour2: at hoursrestart_hour1,restart_hour2This PR:
listversion ofrestart_interval. This list is no longer usable in the coupled model.config.fcstandconfig.efcswill henceforth specify an true restart interval in hours.restart_interval=0will imply writing out restarts at the end of the forecast atFHMAX.In addition, this PR:
developlink_workflow.shforregrid_nemsio.fd,fv3nemsio.fdandenkf_chgres_recenter.fd. These were removed fromgfs-utilsThis work is necessary for enabling coupled ensemble forecasts in cycling mode.
Fixes #496
Type of change
How Has This Been Tested?
CI tests
Checklist