-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make consistent use of restart_interval
across UFS applications
#1700
Changes from 6 commits
62621c9
8aae069
b50eef3
1df9733
5c65670
a8809bb
7801455
307947b
39a649a
e21cf24
b65a5a9
a4fcfae
f2c6156
8e145a5
3eeecf3
d5eca9f
d0333e9
9cf8fb0
61535b2
0614604
41b9afc
38c460c
e7d5c8b
50b7e46
e433c67
86960a0
4748fda
d2f3627
f6765ee
24dd9a4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks like the only changes here are for the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. mostly yes. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -282,19 +282,11 @@ if [[ "${CDUMP}" =~ "gdas" ]] ; then # GDAS cycle specific parameters | |
# Variables used in DA cycling | ||
export DIAG_TABLE="${HOMEgfs}/parm/parm_fv3diag/diag_table_da" | ||
|
||
# Write restart files, where $number is current model start time. | ||
# restart_interval: $number | ||
# number=0, writes out restart files at the end of forecast. | ||
# number>0, writes out restart files at the frequency of $number and at the end of forecast. | ||
# restart_interval: "$number -1" | ||
# writes out restart files only once at $number forecast hour. | ||
# restart_interval: "$number1 $number2 $number3 ..." | ||
# writes out restart file at the specified forecast hours | ||
export restart_interval=${restart_interval:-6} | ||
|
||
# For IAU, write restarts at beginning of window also | ||
|
||
if [[ "${DOIAU}" == "YES" ]]; then | ||
export restart_interval="3 6" | ||
export restart_interval="3" | ||
else | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought the IAU only rewinded There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This change is necessary to address the issue this PR is resolving. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, OK got it. Sorry, this wasn't obvious to me. Thank you! |
||
export restart_interval="6" | ||
fi | ||
|
||
# Choose coupling with wave | ||
|
@@ -309,27 +301,7 @@ elif [[ "${CDUMP}" =~ "gfs" ]] ; then # GFS cycle specific parameters | |
export DIAG_TABLE="${HOMEgfs}/parm/parm_fv3diag/diag_table" | ||
|
||
# Write gfs restart files to rerun fcst from any break point | ||
export restart_interval_gfs=${restart_interval_gfs:-0} | ||
if (( restart_interval_gfs >= 0 )); then | ||
export restart_interval="${FHMAX_GFS}" | ||
else | ||
rst_list="" | ||
IAU_OFFSET=${IAU_OFFSET:-0} | ||
[[ ${DOIAU} == "NO" ]] && export IAU_OFFSET=0 | ||
|
||
for ((xfh=restart_interval_gfs+(IAU_OFFSET/2); xfh <= FHMAX_GFS; xfh=xfh+restart_interval_gfs )); do | ||
rst_list="${rst_list} ${xfh}" | ||
xfh=$((xfh+restart_interval_gfs)) | ||
done | ||
export restart_interval="${rst_list}" | ||
fi | ||
|
||
if [[ "${DO_AERO}" == "YES" ]]; then | ||
# Make sure a restart file is written at the cadence time | ||
if [[ ! "${restart_interval[*]}" =~ ${STEP_GFS} ]]; then | ||
export restart_interval="${STEP_GFS} ${restart_interval}" | ||
fi | ||
fi | ||
export restart_interval=12 | ||
|
||
# Choose coupling with wave | ||
if [[ "${DO_WAVE}" = "YES" && "${WAVE_CDUMP}" != "gdas" ]]; then | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the only changes here are for the
shellnorm
checks, is that correct or am I missing something?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are correct.