Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/coupled-crow updating to use latest ups-weather #210

Conversation

JessicaMeixner-NOAA
Copy link
Contributor

This PR has updates to use ufs-weather-model from 12/7/2020 commit 0cf031e

This will close issue #172

Updates include:

- changed a few names from fv3 to ufs
match ufs-weather-model tests/parm templates for easier
updates and also added updates for frac grid/not frac grid option
…d iovrlw will be replaced by a single iovr option
includes updates to make CICE input file ice_in match the latest
in the rt test options, updates to include fractional grid options (set to false for now),
update to have namelist options iovrsw and iovrlw will be replaced by a single iovr
which was needed after NCAR/ccpp-physics#514
@JessicaMeixner-NOAA
Copy link
Contributor Author

Output from a test can be found on orion at: /work/noaa/marine/jmeixner/p6consitency/test01 and for hera at: /scratch2/NCEPDEV/climate/Jessica.Meixner/p6workflow/test_nonfrac/COMROOT/test02

@jiandewang
Copy link
Contributor

@JessicaMeixner-NOAA can you give me the code and script dir on HERA ?

@JessicaMeixner-NOAA
Copy link
Contributor Author

@jiandewang the local copy of the workflow is here: /scratch2/NCEPDEV/climate/Jessica.Meixner/p6workflow/fracgrid but I have made local changes building on this to test the fractional grid (just in the workflow/cases directory) so FYI it's not a perfect match anymore. Sorry about that. It's not been changed on orion which is here: /work/noaa/marine/jmeixner/p6consitency/global-workflow

@jiandewang
Copy link
Contributor

@JessicaMeixner-NOAA file changes look fine, let me check the results. Your run is frac_grid=F, right ?

@JessicaMeixner-NOAA
Copy link
Contributor Author

@jiandewang correct, there are now flags for fractional grid now but they are all set to false for now

@DeniseWorthen
Copy link

Is there a reason both nems.configure files are retained? nems.configure.med_atm_ocn_ice.IN should be identical to nems.configure.cpld.IN (same for nems.configure.cpld_wave.IN)

@JessicaMeixner-NOAA
Copy link
Contributor Author

No. I'll delete the extra. Thanks for catching that!

Is there a reason both nems.configure files are retained? nems.configure.med_atm_ocn_ice.IN should be identical to nems.configure.cpld.IN (same for nems.configure.cpld_wave.IN)

@jiandewang
Copy link
Contributor

@JessicaMeixner-NOAA I checked your run results, they look good. Since you have run them already I am not going to repeat that, is this fine ?

@JessicaMeixner-NOAA
Copy link
Contributor Author

It worked on multiple platforms for me so I think that sufficiently tested some sort of user environment issue hopefully. So it's okay with me. Thanks for checking everything @jiandewang

@JianKuang-Intelsat JianKuang-Intelsat merged commit c9c2405 into NOAA-EMC:feature/coupled-crow Dec 11, 2020
WalterKolczynski-NOAA added a commit to WalterKolczynski-NOAA/global-workflow that referenced this pull request Jan 13, 2021
…kflow into feature/port_coupled_wcoss_dell

* 'feature/coupled-crow' of github.com:NOAA-EMC/global-workflow:
  Feature/gfsv16intocoupled (NOAA-EMC#194)
  feature/coupled-crow fractional grid  (NOAA-EMC#218)
  updating module file so that atm pos will work (NOAA-EMC#214)
  feature/coupled-crow updating to use latest ups-weather (NOAA-EMC#210)
  feature/coupled-crow: Updates for consistency  (NOAA-EMC#199)
  modify modulefile.reg2grb2.orion, modulefile.reg2grb2.hera and build_reg2grb2.sh to use hpc-stack library
  update readme to current wave post status
  rest of post jobs that should have been committed
  at this point, the post jobs for the waves post run, but the gridded grib2 files are not correct
  modifications for wave jobs after updating to be closer to v16 wave scripts but work for feature/coupled-crow
  update ENV files for wave jobs
  update wave jobs
  updates from gfsv16b-waves
  add correct path to wave exe
  remove exit
  update ww3 build script
  add building of WW3 pre and prep jobs currently requires extra module files (can be removed when base uses hpc-stack)
  update for module files on orion and adding building of wave prep
  updating scrip files for waves to match gfsv16b
  updating ush files for waves to match gfsv16b (includes restructure)
  cleanup
  (1) set IC dir path as /work/noaa/marine/Partha.Bhattacharjee/IC_Dir in workflow/platforms/orion.yaml (2) add extra white space in ush/nems_configure.sh in line 56 to eliminate warning in run log (3) correction on restart_n template variable setting in ush/nems.configure.med_atm_ocn_ice.IN
  corrections on E-P calculation in regdiag.f
  final updates to make cmeps forecasts run
  add pointer to which mediator restart for cmeps
  updates for CMEPS mediator
  adding MED pets so that they only use the forecast not write grid pets
  updates for nems.configure for running with CMEPS
  updating ice_in see NOAA-EMC/CICE5#25
  adding nems.configure to the log file
  add note to use rocoto/1.3.2 on orion as this version has fix for the UNAVAILABLE issue
  reg2grb2 now builds on orion
  updates of an lmod->lmod/lmod update to build of fv3_coupled
  updates for wave post jobs - changing exe dir location
  updating build to work with CMEPS
  cleanup from duplications
  adding cycle definition to wave post job
  fixing syntax error in JWAVE_PREP job for variables that are not actively being used
  change for lmod -> lmod/lmod on orion updated README
  updates - everything but wave post seems to run now, part of wave post does updating model to latest tag
  add waves to jglobal forecast config
  updated wave-realted scripts to match gfsv16 branch updated environment files env/ORION.env updated configuration system
  fix nems.configure for cold start
  at this point the ocean post is now running
  updates for forecast with waves
  updating forecast job for wave jobs
  updates to run wave prep for s2s case
  wave init now works on orion
  put ic type variable into config.fv3ic
  add ocean, ice and wave configurable variables
  add ocean, ice and wave configurable variables
  adding missing file from last commit
  wave init job now works on hera
  ocean post hours at boundary are processed twice, now fixed.
  point WW3-related executables through HOMEgfs/fv3_coupled.fd/exec
  updates for running wave jobs
  updates for wave defaults for s2s p4
  fix bugs in config.wave and coupled_ic.sh
  first try for adding wave ICs
  move OCNPETS, ICEPETS and WAVEPETS into dedicated model-specific sessions instead of fv3_gfs_settings
  bug fix in layout file
  bugfix in layout file
  changes to wave case
  cleaning up double cplwav
  adding updates to wave scripts from gfsv16b branch by @ajhenrique
  add ocn-ice build to readme
  Merged and ready for test
  reg2grb2 Build on Hera and Orion
  orion hera build test
  reg2grb2 for test on feature coupled-crow
  wave post-process job update
  Revise CCPP_SUITE variable name, default option, to "IPD"
  Fix suite name of CCPP Move cplwav and cplwav2atm variable
  1, Moved some of the variables into configuration system from JWAVE scripts 2, Wave configuration system built out 3, Modularized scripts updated to accomodate wave variables
  fix module-setup.sh.inc script, which causes module purge unsuccessful
  wave configuration update
  wave configuration files
  both forecast and atm post seem to be running okay on orion
  updating module_base.orion that allows cold start to run. Not sure if other jobs will now fail though or if what is in your .bashrc file will effect the success/failure of the run.
  fix typo
  updates for tar files and do not keep data
  adding ncks, updating ocean post, some fixes for tar files
  mediator cold start succeeds on hera and forecast job starts post jobs for atmosphere are no longer triggered on cold starts
  updates to readme for orion
  updating module files on hera
  we don't want to cycle/have 4 runs per day so setting the cases to be just 1 IC
  updating module files to match s2s model and ncep post modules
  last of archive updates for p4
  updating for reorganized tar files, pulling in changes from wcoss-p2 workflow
  making a fix dir of all available ccpp suite files copying suite xml file to rundirectory
  updates for CCPP suite used in p4
  updates for ice_in to match prototype 4
  update diag_table for ocean
  renaming exe to reflect updated build
  updates for new fix (which includes prep for multiple resolutions) and some clean-up
  more updates for ICs
  updates for copying ICs
  replace MOM6IC with BASE_CPLIC for base directory location of IC for s2s model and made it platform dependent. (Orion location is temporary and needs to be replaced, can also be changed in cases/coupled_free_forecast.yaml to users prefered location)
  fixed error when linking on hera
  removing fix from .gitignore
  making Externals_coupled.cfg consistent with checkout.sh
  update UPP version to v1.0.8
  updates to checkout, build and link to run prototype 4
  automate fix file linking, to this location: /work/noaa/marine/jmeixner/tempFixICdir/fix/fix_prep_benchmark3
  expand gitignore
  case file adjustment for Orion IC
  update checkout and External.cfg
  checkout and External.cfg update
  remove HERA-like paths in platform.yaml of Orion
  port to Orion
  reiflag default value changed to 1
  generalize fix file directory for imp_physics 8
  configuration update for CCPP scripts
  turn off stochastic features in case file
  update on sandbox platform, for FIX_SCRUB settings
  delete falseful copy after namelist and model_configure parsing add FNMSKH conditional clause, coupled vs non-coupled
  stochastic variables update
  OCNTIM and ICETIM are included in config.fv3 ice variable istep0 bug fix
  stochy variable namelist update, add hard-coded variables into config.fcst (fcst.yaml)
  capital case CDUMP values in config.fv3
  add stoch variables to config.fcst scripts update: CCPP and IPD works
  merge in the latest revision from IPD work
  model_configure_DATM
  move all default values into /defaults from /schema
  clean up unused schema move default value into defaults/
  Clean up exwave_post_sbs
  Moving standalone fv3 model_config exglobal_fcst block into if/else/fi cplwav model_config block. Reinstating config.wave block in JGLOBAL_FORECAST. Pointing EXECwave to HOMEgfs/exec directory for WW3 util executables (changed link_fv3gfs.sh accordingly). Removing debug options from compile.sh line in build_fv3.sh.
  Fix to JWAVE_PREP to look back a day for rtofs
  Squashing commits to wave2global
  bug fix, POSTGRB2TBL undefined
  Pointing to v3.1 tag for ufs-s2s-model making readme consistant with user.yaml.default
@JessicaMeixner-NOAA JessicaMeixner-NOAA deleted the coupled/consistencyupdates branch January 28, 2021 21:39
lgannoaa pushed a commit to lgannoaa/global-workflow that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants