Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix paths in prepocnobs task #2459

Merged
merged 26 commits into from
Apr 12, 2024
Merged

Fix paths in prepocnobs task #2459

merged 26 commits into from
Apr 12, 2024

Conversation

AndrewEichmann-NOAA
Copy link
Contributor

Description

This PR fixes path for exglobal_prep_ocean_obs.py in jobs/JGLOBAL_PREP_OCEAN_OBS and associated config file

Fixes #2353, replaces PR #2356

Will break GDASApp ctests if g-w link script not run first, this will be amended in GDASApp

Type of change

  • Bug fix (fixes something broken)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

GDASApp global-workflow ctests on Hera

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@AndrewEichmann-NOAA
Copy link
Contributor Author

FYI @guillaumevernieres

guillaumevernieres
guillaumevernieres approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AndrewEichmann-NOAA

aerorahul
aerorahul requested changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few items to address.

parm/config/gfs/config.prepoceanobs Outdated Show resolved Hide resolved
parm/config/gfs/config.prepoceanobs Outdated Show resolved Hide resolved
parm/config/gfs/config.prepoceanobs Outdated Show resolved Hide resolved
parm/config/gfs/config.prepoceanobs Outdated Show resolved Hide resolved
@AndrewEichmann-NOAA AndrewEichmann-NOAA marked this pull request as ready for review April 5, 2024 21:03
aerorahul
aerorahul reviewed Apr 5, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the issue is to fix paths in prepocenobs task, then perhaps it would be great if all paths in the config.prepoceanobs use PARMgfs instead of referring the parm files from sorc/gdas.cd.

AndrewEichmann-NOAA and others added 2 commits April 5, 2024 17:13
@AndrewEichmann-NOAA @aerorahul
Update parm/config/gfs/config.prepoceanobs
670bee6 
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
@AndrewEichmann-NOAA
more tweaks
d40eeca
@AndrewEichmann-NOAA
Copy link
Contributor Author

@aerorahul @WalterKolczynski-NOAA @guillaumevernieres should be good to go

aerorahul
aerorahul approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@AndrewEichmann-NOAA AndrewEichmann-NOAA mentioned this pull request Apr 9, 2024
Closed
guillaumevernieres
guillaumevernieres approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AndrewEichmann-NOAA

@AndrewEichmann-NOAA AndrewEichmann-NOAA mentioned this pull request Apr 10, 2024
Merged
@AndrewEichmann-NOAA AndrewEichmann-NOAA mentioned this pull request Apr 12, 2024
Closed
guillaumevernieres pushed a commit to NOAA-EMC/GDASApp that referenced this pull request Apr 12, 2024
@AndrewEichmann-NOAA
Run g-w linker script before ctest for prepoceanobs task (#1034)
fadffb0 
In anticipation of the merging of
NOAA-EMC/global-workflow#2459 , the
`test_gdasapp_soca_setup_obsprep` ctest which sets up for
`test_gdasapp_soca_JGLOBAL_PREP_OCEAN_OBS` now runs the global-workflow
`sorc/link_workflow.sh` script to allow the observation config files to
be accessed in a global-workflow-compliant way.

Effectively addresses #1032
aerorahul
aerorahul approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@aerorahul aerorahul merged commit 80e4684 into NOAA-EMC:develop Apr 12, 2024
4 checks passed
danholdaway added a commit to danholdaway/global-workflow that referenced this pull request Apr 15, 2024
@danholdaway
Merge remote-tracking branch 'upstream/develop' into feature/use_jcb_atm
c784cc8 
* upstream/develop:
  Update fbwind for COM refactor (NOAA-EMC#2479)
  Update parm files for atm product (NOAA-EMC#2486)
  Fix paths in prepocnobs task (NOAA-EMC#2459)
  Add oceanalecn to workflow generator (NOAA-EMC#2409)
  Add support for CADS IR cloud detection scheme in the GSI (NOAA-EMC#2478)
  Improve error messaging to resolve bugzilla (NOAA-EMC#2468)
  Check the DO_JEDISNOWDA condition before adding snow DA analysis to the list (NOAA-EMC#2471)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerorahul aerorahul aerorahul approved these changes

@WalterKolczynski-NOAA WalterKolczynski-NOAA Awaiting requested review from WalterKolczynski-NOAA WalterKolczynski-NOAA is a code owner

@guillaumevernieres guillaumevernieres Awaiting requested review from guillaumevernieres

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix path for exglobal_prep_ocean_obs.py in JJOB
4 participants
@AndrewEichmann-NOAA @aerorahul @guillaumevernieres @ShastriPaturi