Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add UPP to hpc-stack #63

Closed
wants to merge 10 commits into from
Closed

add UPP to hpc-stack #63

wants to merge 10 commits into from

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented Nov 14, 2020 •
edited
Loading

This PR:

Change-Id: I09a155ef0e026d8fac682390f05e9c2dd9c7c2d4

@aerorahul
add UPP to hpc-stack
85f433d 
Change-Id: I09a155ef0e026d8fac682390f05e9c2dd9c7c2d4
@aerorahul aerorahul requested a review from climbfuji November 14, 2020 00:57
@aerorahul
Copy link
Contributor Author

Looks like there is a bug in upp_v10.0.0

@aerorahul aerorahul closed this Nov 16, 2020
aerorahul and others added 4 commits November 16, 2020 15:16
@aerorahul
prevent over-writing already created metamodules and stack modulefile (…
c113669 
…#66)
@MinsukJi-NOAA
Add stack yaml file for ufs weather ci test (#68)
6e81c6c 
* Add stack yaml file for ufs weather ci test
@kgerheiser
Update grib_util to v1.2.2 so it can build with GCC 10 (#79)
30a58ab
@aerorahul
Bring the stack to Gaea. (#70)
b6c69e0 
* build hpc-stack on Gaea.  Refinements for build_esmf with cray-mpich.
Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com>
@kgerheiser
Copy link
Contributor

I don't know why it does that here specifically. I was able to build the tag fine, and it builds on the Action I setup for their repository.

@aerorahul
Copy link
Contributor Author

Yeah. I haven't got to why yet. Help appreciated. Mind boggling indeed.

@climbfuji
Copy link
Contributor

What is the problem?

@kgerheiser
Copy link
Contributor

https://github.com/NOAA-EMC/hpc-stack/pull/63/checks#step:4:23250

@edwardhartnett
Copy link
Contributor

Do we need this PR to work for the 1.1.0 release? Seems like that is implied by #71

@aerorahul
Copy link
Contributor Author

Yes.

@edwardhartnett edwardhartnett mentioned this pull request Nov 19, 2020
Closed
@kgerheiser
Copy link
Contributor

kgerheiser commented Nov 19, 2020 •
edited
Loading

Maybe related, maybe not, but is there a problem with building two versions of UPP, v10.0.0 and the dcea26 version? When installed in a flat structure, as we do on the Github Runner, modules like vrbls3d will overwrite one another? Or it picks up the one module first and it doesn't contain some of the variables?

@aerorahul
Copy link
Contributor Author

Good point @kgerheiser
I'll disable nceppost in the runner and keep UPP and then re-run the ci.
Let's see.

@climbfuji
Copy link
Contributor

Good point @kgerheiser
I'll disable nceppost in the runner and keep UPP and then re-run the ci.
Let's see.

Great finding, @kgerheiser. We don't need both at the same time, as far as I can see.

@aerorahul aerorahul reopened this Nov 20, 2020
@aerorahul
Copy link
Contributor Author

reopened this PR.
The CI was successful with nceppost turned off. @kgerheiser was correct to identify the issue in the comments above. Thanks @kgerheiser

@aerorahul aerorahul requested a review from kgerheiser November 20, 2020 04:04
@aerorahul
Copy link
Contributor Author

woops. missing something here.

@aerorahul aerorahul closed this Nov 20, 2020
@aerorahul aerorahul mentioned this pull request Nov 20, 2020
Merged
@aerorahul aerorahul deleted the feature/upp branch November 20, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@climbfuji climbfuji Awaiting requested review from climbfuji

@kgerheiser kgerheiser Awaiting requested review from kgerheiser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the nceppost with request by using the 10.0.0 version
5 participants
@aerorahul @kgerheiser @climbfuji @edwardhartnett @MinsukJi-NOAA