Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent over-writing already created metamodules and stack modulefile #66

Merged
merged 1 commit into from
Nov 16, 2020
Merged

prevent over-writing already created metamodules and stack modulefile #66

merged 1 commit into from
Nov 16, 2020

Conversation

aerorahul
Copy link
Contributor

This PR:

  • adds a layer of security that warns the user that modulefiles for the compiler and MPI are already present and queries the user if they want to over-write them. In most (almost all), the answer is NO, since these just load the underlying compiler module file or use the system compiler/MPI.
  • fixes Improve setup_modules.sh interface #65

@aerorahul aerorahul requested a review from kgerheiser November 16, 2020 18:49
@kgerheiser
Copy link
Contributor

Worked for me

@aerorahul aerorahul merged commit c113669 into NOAA-EMC:develop Nov 16, 2020
@aerorahul aerorahul deleted the feature/improve_setup_modules branch November 16, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgerheiser kgerheiser kgerheiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve setup_modules.sh interface
2 participants
@aerorahul @kgerheiser