Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dmUpdate: move type declaration and change type for nvhpc #1463

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Feb 22, 2024

Description
fixes compilation errors related to the diag manager updates when building with nvhpc. Had to move a type declaration to be before any references to it and switch a class to a type.

I still ran into runtime errors when running the unit testing with nvhpc.

How Has This Been Tested?
built with nvhpc on amd box (23.11) and gaea (22.3)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@rem1776 rem1776 merged commit 01ee952 into NOAA-GFDL:dmUpdate Feb 22, 2024
17 of 19 checks passed
@rem1776 rem1776 mentioned this pull request Mar 4, 2024
8 tasks
rem1776 added a commit to rem1776/FMS that referenced this pull request May 1, 2024
rem1776 added a commit to rem1776/FMS that referenced this pull request May 1, 2024
rem1776 added a commit to rem1776/FMS that referenced this pull request May 1, 2024
rem1776 added a commit to rem1776/FMS that referenced this pull request May 1, 2024
rem1776 added a commit to rem1776/FMS that referenced this pull request May 1, 2024
rem1776 added a commit to rem1776/FMS that referenced this pull request May 1, 2024
rem1776 added a commit to rem1776/FMS that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants