dmUpdate: fix nvhpc compile error #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exchange/xgrid.F90
Outdated
Comment on lines
1599
to
1601
| ! nvhpc compiler workaround | ||
| ! saves passed in xmap as an allocatable | ||
| ! this lets us use a normal assignment instead of a pointer assignment in the loop to avoid a compiler error |
There was a problem hiding this comment.
Do we need to report this to nvidia?
There was a problem hiding this comment.
Let's make sure we have tested using the very latest nvhpc 24.3 before filing a bug with NVidia.
There was a problem hiding this comment.
The xgrid compilation error was pretty hard to reproduce, Niki first saw this using 22.3 and I've only been able to get the error using his xml to compile. I don't seem to get the error when i compile with autotools, and didn't even get it when i tried compiling one of my xml's with nvidia.
There was a problem hiding this comment.
We can get the makefile and everything else needed and send it to them
added 2 commits
March 19, 2024 11:25
thomas-robinson
approved these changes
Mar 19, 2024
rem1776
added a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
added a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
added a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
added a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
added a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
added a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
added a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a nvidia compilation error coming from the diag_manager updates. I missed this one in PR #1463 because i was only using autotools. Interestingly this error seems to only happen with mkmf, even if i use the same target flags for autotools.
Just adds a nested select type for when assigning a class(*) field to a character variable.
How Has This Been Tested?
mkmf on gaea with nvhpc/22.3, autotools build on amd with nvhpc/23.11
Checklist:
make distcheckpasses