TC MSE POD Proposal for Incorporation into NOAA's Repo #448
Conversation
new file: diagnostics/TC_MSE/Plotting.py new file: diagnostics/TC_MSE/Plotting_Functions.py new file: diagnostics/TC_MSE/TC_MSE_Driver.py new file: diagnostics/TC_MSE/TC_snapshot_MSE_calc.py new file: diagnostics/TC_MSE/doc/TC_MSE.rst
jcstarr
requested review from
jkrasting,
wrongkindofdoctor and
aradhakrishnanGFDL
as code owners
wrongkindofdoctor
added
the
diagnostic
|
@jcstarr Thank you! Please email the tarball to Dani, and cc me in case there are issues that I need to debug. I and @jkrasting will do our best to provide initial reviews of your POD by the end of the week. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
|
If you can email the data, please go ahead and do so! I'm ***@***.***
…On Fri, Feb 24, 2023 at 3:32 PM jcstarr ***@***.***> wrote:
*Description*
This is the first pull request for getting Dr. Allison Wing’s POD on the
tropical cyclone moist static energy variance budget (TC_MSE) reviewed. We
have gone over the checklist and run through the POD on our end and
everything has run successfully. The plots that are created from this POD
have been attached in this pull request.
The obs_data files have been organized into a .tar file as well as a
README for how it was generated. The code used to generate the pre-digested
obs data as well as its README is in a separate .tar file in the doc
directory (per the request to include the code used to generate our POD’s
digested data from raw data sources.) The obs_data tar file is ~20 MB so it
should be able to be emailed – is it still Dani that they should be emailed
to or someone else? The model data this POD was run on is different than
the framework-provided test dataset; we tested it on 5 years of AM4 data
that John Krasting provided to us (matching the CMIP6 GFDL CM4 AMIP
simulation).
First pull request for TC MSE POD
*How Has This Been Tested?*
The POD has been run on our remote branch and has run successfully. The
POD takes approximately 50 minutes to run from start to finish. The code
was made and run using the most up to date version of the framework and
python version 3.10.9.
*Checklist:*
Checked through all the items listed.
*Figures generated by the POD*
Panel_Composites_15_18_Bin.pdf
<https://github.com/NOAA-GFDL/MDTF-diagnostics/files/10829046/Panel_Composites_15_18_Bin.pdf>
Panel_Composites_18_21_Bin.pdf
<https://github.com/NOAA-GFDL/MDTF-diagnostics/files/10829047/Panel_Composites_18_21_Bin.pdf>
Panel_Composites_21_24_Bin.pdf
<https://github.com/NOAA-GFDL/MDTF-diagnostics/files/10829048/Panel_Composites_21_24_Bin.pdf>
Panel_Composites_24_27_Bin.pdf
<https://github.com/NOAA-GFDL/MDTF-diagnostics/files/10829049/Panel_Composites_24_27_Bin.pdf>
Panel_Composites_27_30_Bin.pdf
<https://github.com/NOAA-GFDL/MDTF-diagnostics/files/10829050/Panel_Composites_27_30_Bin.pdf>
Multibin_Azmean_Plots.pdf
<https://github.com/NOAA-GFDL/MDTF-diagnostics/files/10829051/Multibin_Azmean_Plots.pdf>
Box_Average_Plots.pdf
<https://github.com/NOAA-GFDL/MDTF-diagnostics/files/10829052/Box_Average_Plots.pdf>
Normalized_Box_Average_Plots.pdf
<https://github.com/NOAA-GFDL/MDTF-diagnostics/files/10829054/Normalized_Box_Average_Plots.pdf>
Scattered_Feedbacks.pdf
<https://github.com/NOAA-GFDL/MDTF-diagnostics/files/10829056/Scattered_Feedbacks.pdf>
------------------------------
You can view, comment on, or merge this pull request online at:
#448
Commit Summary
- 8c00b6f
<8c00b6f>
new file: diagnostics/TC_MSE/Binning_and_compositing.py
- e3068fb
<e3068fb>
new file: src/config.jsonc
- 33a5cf6
<33a5cf6>
new file: diagnostics/TC_MSE/settings.jsonc
- 067f5ab
<067f5ab>
new file: diagnostics/TC_MSE/doc/Box_Average_Plot.jpg
- 24699fb
<24699fb>
Update TC_MSE.rst
- 16dda92
<16dda92>
new file: diagnostics/TC_MSE/TC_MSE.html
- 2f73015
<2f73015>
Merge branch 'TC_MSE' of https://github.com/jcstarr/MDTF-diagnostics
into TC_MSE
- 4c69c51
<4c69c51>
Updated .rst, plot function, and .rst jpg image
- 5a14791
<5a14791>
Updataed jpg image for .rst file
- 13b7fd7
<13b7fd7>
Updated .rst file
- e77ed9b
<e77ed9b>
Updated jpg image for .rst file
- 368e601
<368e601>
Updated .rst file
- f4a56ab
<f4a56ab>
Remove print statements in binning code
- 9ae89ce
<9ae89ce>
.tar file with all the predigested code
File Changes
(11 files <https://github.com/NOAA-GFDL/MDTF-diagnostics/pull/448/files>)
- *A* diagnostics/TC_MSE/Binning_and_compositing.py
<https://github.com/NOAA-GFDL/MDTF-diagnostics/pull/448/files#diff-8c6bfcaced55334def11bfc34760686b3b01f2587dcae087f25d5b479ee0eebc>
(178)
- *A* diagnostics/TC_MSE/Plotting.py
<https://github.com/NOAA-GFDL/MDTF-diagnostics/pull/448/files#diff-cc861acf334a0e04b04ac9b75e6c1fa19140796e682e959a696deb6038a6f3e8>
(19)
- *A* diagnostics/TC_MSE/Plotting_Functions.py
<https://github.com/NOAA-GFDL/MDTF-diagnostics/pull/448/files#diff-82b853f18a88e2f4766d6fed5faa3803e474f2ed7ffdebad1ab79df32d7861c3>
(952)
- *A* diagnostics/TC_MSE/TC_MSE.html
<https://github.com/NOAA-GFDL/MDTF-diagnostics/pull/448/files#diff-67e22ae430204340a564d13feb05306cc52a9605f522e8cd66bf43f06bc21a81>
(27)
- *A* diagnostics/TC_MSE/TC_MSE_Driver.py
<https://github.com/NOAA-GFDL/MDTF-diagnostics/pull/448/files#diff-abf2c0f0e6380b80c3ccf3b13346ab5336b4e63bff09b280e3a2843461951aed>
(34)
- *A* diagnostics/TC_MSE/TC_snapshot_MSE_calc.py
<https://github.com/NOAA-GFDL/MDTF-diagnostics/pull/448/files#diff-a354fd5364f8849c994d39bcead708215748053d03a233bd6f2882147db5592a>
(541)
- *A* diagnostics/TC_MSE/doc/Box_Average_Plot.jpg
<https://github.com/NOAA-GFDL/MDTF-diagnostics/pull/448/files#diff-a19fd9f6201292a1c2fe98b97a498b8cb88d5bf699f53a50177622ae01f936a8>
(0)
- *A* diagnostics/TC_MSE/doc/TC_MSE.rst
<https://github.com/NOAA-GFDL/MDTF-diagnostics/pull/448/files#diff-22b0b5e0e4ac87863dbe4f6be7bd7beb0f57ffd2ad3d5b192901b5a5e15fabfe>
(132)
- *A* diagnostics/TC_MSE/doc/TC_MSE_predigested_code.tar
<https://github.com/NOAA-GFDL/MDTF-diagnostics/pull/448/files#diff-5a5258c9c417bc599a9bad1be9a0aae49fd0081c8200f5380e310903e837a44c>
(0)
- *A* diagnostics/TC_MSE/settings.jsonc
<https://github.com/NOAA-GFDL/MDTF-diagnostics/pull/448/files#diff-68c4adfe843aff2026f96a73ee8001a3a1753a1cd814667b7282499bb402cc7f>
(148)
- *A* src/config.jsonc
<https://github.com/NOAA-GFDL/MDTF-diagnostics/pull/448/files#diff-55ba1e5ad4e7e4e41ad92dd97d20a96a015d411df3aa5f4f07db2c3acf41e5ed>
(134)
Patch Links:
- https://github.com/NOAA-GFDL/MDTF-diagnostics/pull/448.patch
- https://github.com/NOAA-GFDL/MDTF-diagnostics/pull/448.diff
—
Reply to this email directly, view it on GitHub
<#448>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHLJVQAZMETOR3SDI77W32DWZEZJXANCNFSM6AAAAAAVHNIK5M>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Allison has sent the .tar files over email, if they did not go through then please let us know and we can try again. Thank you! |
… on specific 1979-1983 years
…wline at the end of the code
…hatever the input years the user gives
… in the example figure below the statement.
Description
This is the first pull request for getting Dr. Allison Wing’s POD on the tropical cyclone moist static energy variance budget (TC_MSE) reviewed. We have gone over the checklist and run through the POD on our end and everything has run successfully. The plots that are created from this POD have been attached in this pull request.
The obs_data files have been organized into a .tar file as well as a README for how it was generated. The code used to generate the pre-digested obs data as well as its README is in a separate .tar file in the doc directory (per the request to include the code used to generate our POD’s digested data from raw data sources.) The obs_data tar file is ~20 MB so it should be able to be emailed – is it still Dani that they should be emailed to or someone else? The model data this POD was run on is different than the framework-provided test dataset; we tested it on 5 years of AM4 data that John Krasting provided to us (matching the CMIP6 GFDL CM4 AMIP simulation).
First pull request for TC MSE POD
How Has This Been Tested?
The POD has been run on our remote branch and has run successfully. The POD takes approximately 50 minutes to run from start to finish. The code was made and run using the most up to date version of the framework and python version 3.10.9.
Checklist:
Checked through all the items listed.
Figures generated by the POD
Panel_Composites_15_18_Bin.pdf
Panel_Composites_18_21_Bin.pdf
Panel_Composites_21_24_Bin.pdf
Panel_Composites_24_27_Bin.pdf
Panel_Composites_27_30_Bin.pdf
Multibin_Azmean_Plots.pdf
Box_Average_Plots.pdf
Normalized_Box_Average_Plots.pdf
Scattered_Feedbacks.pdf