Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: Default to decaying adjustment factor #103

Merged
merged 2 commits into from
Jul 20, 2021
Merged

events: Default to decaying adjustment factor #103

merged 2 commits into from
Jul 20, 2021

Conversation

jarq6c
Copy link
Collaborator

@jarq6c jarq6c commented Jul 20, 2021

Recent versions of pandas no longer allow the combination of a halflife with the recursive version of the EWMA. This changes the default to use a decaying adjustment factor.

Additions

  • None

Removals

  • None

Changes

  • Use decaying adjustment factor.

Testing

  1. Passes tests.

Notes

  • Slight change to EWMA algorithm.

Todos

Checklist

  • PR has an informative and human-readable title
  • PR is well outlined and documented. See #12 for an example
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (see CONTRIBUTING.md)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output) using numpy docstring formatting
  • Placeholder code is flagged / future todos are captured in comments
  • Reviewers requested with the Reviewers tool ➡️

@jarq6c jarq6c added the bug Something isn't working label Jul 20, 2021
@jarq6c jarq6c self-assigned this Jul 20, 2021
@jarq6c jarq6c merged commit 26e516f into NOAA-OWP:main Jul 20, 2021
@jarq6c jarq6c deleted the update_events branch July 20, 2021 23:06
aaraney added a commit to aaraney/hydrotools that referenced this pull request Sep 19, 2023
@aaraney
bump aiohttp and aiohttp_client_cache version deps
03c7e9d 
See NOAA-OWP#103 for background as to why aiohttp was previously pinned. In
short, the issues that led to pinning aiohttp have be resolved upstream.

aiohttp_client_cache >= 0.9.0 needed b.c.
requests-cache/aiohttp-client-cache#173
@aaraney aaraney mentioned this pull request Sep 19, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jarq6c jarq6c

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jarq6c