-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump _restclient's aiohttp
and aiohttp_client_cache
version deps
#237
Conversation
See NOAA-OWP#103 for background as to why aiohttp was previously pinned. In short, the issues that led to pinning aiohttp have be resolved upstream. aiohttp_client_cache >= 0.9.0 needed b.c. requests-cache/aiohttp-client-cache#173
Simple enough! |
I will open up another PR that bumps the version of this when i'm done testing things out. Im running into an issue with the |
Any idea why this PR would cause the |
I think it is because the source didnt change. Still kind of odd that it failed. |
Having spend a day or so looking at this last week, I don't know that it is going to be as straight forward to fix as I was hoping. Here is a brief-ish explanation.
Inside This means that the runtime of the main event loop must be strictly longer than the These changes would require changes to the semantics of the |
Thanks for the deep-dive @aaraney ! Should we link this to a new issue on the |
@jarq6c, for sure! Yeah, I will open an issue to track this. |
I opened #238 to track this. |
bump
aiohttp
andaiohttp_client_cache
version depsSee #103 for background as to why
aiohttp
was previously pinned. In short, the issues that led to pinningaiohttp
have be resolved upstream.aiohttp_client_cache
>= 0.9.0 needed b.c. requests-cache/aiohttp-client-cache#173Changes
_restclient
depends onaiohttp~=3.8
andaiohttp_client_cache>=0.9.0
Checklist