Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix F-Factor Failures #64

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Fix F-Factor Failures #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d44df13
update Rfilm_in to match Energyplus
eringold Dec 22, 2023
e7c45f4
Update measure.xml
mdahlhausen Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions resources/measures/create_typical_building_from_model/measure.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>create_typical_building_from_model</name>
<uid>339a2e3a-273c-4494-bb50-bfe586a0647c</uid>
<version_id>d4d8e1ca-a5db-47e0-aae1-f98dad728eb8</version_id>
<version_modified>2023-10-16T20:24:52Z</version_modified>
<version_id>e0d7a67d-835a-43a5-9698-36b20ceda38f</version_id>
<version_modified>2024-01-02T15:25:32Z</version_modified>
<xml_checksum>EE13F09F</xml_checksum>
<class_name>CreateTypicalBuildingFromModel</class_name>
<display_name>Create Typical Building from Model</display_name>
Expand Down Expand Up @@ -1475,7 +1475,7 @@
<filename>os_lib_model_generation.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>7AA832CC</checksum>
<checksum>3097D1DE</checksum>
</file>
<file>
<filename>GenericGbxml.osm</filename>
Expand Down
4 changes: 2 additions & 2 deletions resources/measures/create_typical_building_from_model/resources/os_lib_model_generation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2697,8 +2697,8 @@ def typical_building_from_model(model, runner, user_arguments)

# adjust F factor constructions to avoid simulation errors
model.getFFactorGroundFloorConstructions.each do |cons|
# Rfilm_in = 0.125, Rfilm_out = 0.03, Rcons = 0.15/1.95
if cons.area <= (0.125 + 0.03 + 0.15/1.95) * cons.perimeterExposed * cons.fFactor
# Rfilm_in = 0.135, Rfilm_out = 0.03, Rcons = 0.15/1.95
if cons.area <= (0.135 + 0.03 + 0.15/1.95) * cons.perimeterExposed * cons.fFactor
# set minimum Rfic to > 1e-3
new_area = 0.233 * cons.perimeterExposed * cons.fFactor
runner.registerInfo("F-factor fictitious resistance for #{cons.name.get} with Area=#{cons.area.round(2)}, Exposed Perimeter=#{cons.perimeterExposed.round(2)}, and F-factor=#{cons.fFactor.round(2)} will result in a negative value and a failed simulation. Construction area is adjusted to be #{new_area.round(2)}.")
Expand Down