Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix F-Factor Failures #64

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Fix F-Factor Failures #64

merged 2 commits into from
Jan 2, 2024

Conversation

eringold
Copy link
Contributor

@eringold eringold commented Dec 22, 2023 •
edited by mdahlhausen
Loading

Pull request overview

Update Rfilm_in in F-factor area override to match EnergyPlus

Pull Request Author

This pull request makes changes to (select all the apply):

  • Workflow Measures

Author pull request checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: data and method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • Reviewed change documentation
  • Ensured code files contain License reference
  • Results differences are reasonable
  • CI status: all tests pass

ComStock Licensing Language - Add to Beginning of Each Code File

# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.

@eringold eringold added the workflow measure PR improves or adds baseline workflow measures label Dec 22, 2023
@eringold eringold mentioned this pull request Dec 22, 2023
Merged
8 tasks
@eringold eringold changed the title update Rfilm_in to match Energyplus Fix F-Factor Failures Follow-up Dec 22, 2023
@eringold
Copy link
Contributor Author

openstudio-standards PR: NREL/openstudio-standards#1649

@mdahlhausen mdahlhausen merged commit 0d25489 into main Jan 2, 2024
@mdahlhausen mdahlhausen deleted the ffactorfix branch January 2, 2024 15:26
@eringold eringold restored the ffactorfix branch January 11, 2024 22:13
@mdahlhausen mdahlhausen changed the title Fix F-Factor Failures Follow-up Fix F-Factor Failures Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdahlhausen mdahlhausen mdahlhausen approved these changes

Assignees
No one assigned
Labels
workflow measure PR improves or adds baseline workflow measures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runs failing due to FfactorGroundFloor negative resistance
2 participants
@eringold @mdahlhausen