Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override area for failing ffactor constructions in create typical #1649

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Override area for failing ffactor constructions in create typical #1649

merged 1 commit into from
Jan 2, 2024

Conversation

eringold
Copy link
Collaborator

Pull request overview

mirrors NREL/ComStock#64

Pull Request Author

  • Method changes or additions

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

@eringold eringold mentioned this pull request Dec 22, 2023
Merged
9 tasks
@mdahlhausen mdahlhausen merged commit 1d3c75f into master Jan 2, 2024
1 of 2 checks passed
@mdahlhausen mdahlhausen deleted the ffactorfix branch January 2, 2024 15:23
@mdahlhausen mdahlhausen changed the title override area for failing ffactor cons in create_typical Override area for failing ffactor constructions in create_typical Apr 9, 2024
@mdahlhausen mdahlhausen changed the title Override area for failing ffactor constructions in create_typical Override area for failing ffactor constructions in create typical Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdahlhausen mdahlhausen mdahlhausen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eringold @mdahlhausen