Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct PVAV coil type #67

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Correct PVAV coil type #67

merged 1 commit into from
Jan 3, 2024

Conversation

mdahlhausen
Copy link
Contributor

@mdahlhausen mdahlhausen commented Jan 3, 2024 •
edited
Loading

  • change 'PVAV with gas heat with electric reheat' to use a gas coil instead of a hot water coil with a boiler
  • add 'PVAV with gas coil heat with electric reheat', which is another name for the setup
  • add 'PVAV with gas boiler heat with electric reheat' for the option with a hot water coil with a boiler

Pull Request Author

This pull request makes changes to (select all the apply):

  • Workflow Measures

Author pull request checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Updated measure .xml(s)
  • 10k+ test run
  • All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: data and method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • Reviewed change documentation
  • Ensured code files contain License reference
  • Results differences are reasonable
  • CI status: all tests pass

@mdahlhausen
change PVAV coil type
cbfff2f 
change 'PVAV with gas heat with electric reheat' to use a gas coil instead of a hot water coil with a boiler
add 'PVAV with gas coil heat with electric reheat', which is another name for the setup.
add 'PVAV with gas boiler heat with electric reheat' for the option with a hot water coil with a boiler
@mdahlhausen mdahlhausen added the workflow measure PR improves or adds baseline workflow measures label Jan 3, 2024
@mdahlhausen mdahlhausen merged commit 4713df1 into main Jan 3, 2024
@mdahlhausen mdahlhausen deleted the fix/pvav_gas branch January 3, 2024 18:57
@eringold eringold restored the fix/pvav_gas branch January 8, 2024 16:22
@mdahlhausen mdahlhausen changed the title change PVAV coil type Correct PVAV coil type Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eringold eringold eringold approved these changes

@mpraprost mpraprost Awaiting requested review from mpraprost

Assignees

@eringold eringold

Labels
workflow measure PR improves or adds baseline workflow measures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdahlhausen @eringold