Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct PVAV coil type #67

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Correct PVAV coil type #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions resources/measures/create_typical_building_from_model/measure.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,8 @@ def arguments(model)
hvac_chs << 'PVAV with district hot water reheat'
hvac_chs << 'PVAV with PFP boxes'
hvac_chs << 'PVAV with gas heat with electric reheat'
hvac_chs << 'PVAV with gas coil heat with electric reheat'
hvac_chs << 'PVAV with gas boiler heat with electric reheat'
hvac_chs << 'Residential AC with baseboard electric'
hvac_chs << 'Residential AC with baseboard gas boiler'
hvac_chs << 'Residential AC with baseboard central air source heat pump'
Expand Down
16 changes: 12 additions & 4 deletions resources/measures/create_typical_building_from_model/measure.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>create_typical_building_from_model</name>
<uid>339a2e3a-273c-4494-bb50-bfe586a0647c</uid>
<version_id>e0d7a67d-835a-43a5-9698-36b20ceda38f</version_id>
<version_modified>2024-01-02T15:25:32Z</version_modified>
<version_id>5815cc73-0b2b-46bc-9ae2-7ead558f15ce</version_id>
<version_modified>2024-01-03T18:32:46Z</version_modified>
<xml_checksum>EE13F09F</xml_checksum>
<class_name>CreateTypicalBuildingFromModel</class_name>
<display_name>Create Typical Building from Model</display_name>
Expand Down Expand Up @@ -545,6 +545,14 @@
<value>PVAV with gas heat with electric reheat</value>
<display_name>PVAV with gas heat with electric reheat</display_name>
</choice>
<choice>
<value>PVAV with gas coil heat with electric reheat</value>
<display_name>PVAV with gas coil heat with electric reheat</display_name>
</choice>
<choice>
<value>PVAV with gas boiler heat with electric reheat</value>
<display_name>PVAV with gas boiler heat with electric reheat</display_name>
</choice>
<choice>
<value>Residential AC with baseboard electric</value>
<display_name>Residential AC with baseboard electric</display_name>
Expand Down Expand Up @@ -1451,13 +1459,13 @@
<filename>measure.rb</filename>
<filetype>rb</filetype>
<usage_type>script</usage_type>
<checksum>E7221B07</checksum>
<checksum>FF7CA5B1</checksum>
</file>
<file>
<filename>Model.hvac.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>48B87A43</checksum>
<checksum>C6E68B0D</checksum>
</file>
<file>
<filename>deer_vintages.rb</filename>
Expand Down
6 changes: 5 additions & 1 deletion resources/measures/create_typical_building_from_model/resources/Model.hvac.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,11 @@ def add_cbecs_hvac_system(standard, system_type, zones)
when 'PVAV with PFP boxes'
standard.model_add_hvac_system(self, 'PVAV PFP Boxes', ht = 'Electricity', znht = 'Electricity', cl = 'Electricity', zones)

when 'PVAV with gas heat with electric reheat'
when 'PVAV with gas heat with electric reheat', 'PVAV with gas coil heat with electric reheat'
standard.model_add_hvac_system(self, 'PVAV Reheat', ht = 'Gas', znht = 'Electricity', cl = 'Electricity', zones,
air_loop_heating_type = 'Gas')

when 'PVAV with gas boiler heat with electric reheat'
standard.model_add_hvac_system(self, 'PVAV Reheat', ht = 'Gas', znht = 'Electricity', cl = 'Electricity', zones)

# all residential systems do not have ventilation
Expand Down