Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Outputs page grid #231

Closed
bstein opened this issue Oct 5, 2022 · 1 comment
Closed

Fix Outputs page grid #231

bstein opened this issue Oct 5, 2022 · 1 comment
Assignees
@bstein

Comments

@bstein
Copy link
Collaborator

bstein commented Oct 5, 2022

After upgrading angular-ui-grid in issue #225 with PR #228, the table does not appear correctly on the Outputs page when the analysis mode is set to "Algorithmic", as shown in this screenshot:

broken-ui-grid

The reason for this is that the styling in the headerTemplate.html file is not compatible with angular-ui-grid v4.6.3 and later. This file needs to be updated to be compatible with the latest version.
@bstein bstein self-assigned this Oct 5, 2022
bstein added a commit that referenced this issue Oct 5, 2022
@bstein
#231: Fix grid on Options page
573e6da
@bstein bstein mentioned this issue Oct 5, 2022
Merged
@tijcolem
Copy link
Collaborator

tijcolem commented Oct 5, 2022 •
edited
Loading

@bstein Good catch!

tijcolem added a commit that referenced this issue Oct 5, 2022
@tijcolem
Merge pull request #232 from NREL/fix-options-page-grid
e815daf 
#231: Fix grid on Options page
@bstein bstein closed this as completed Oct 5, 2022
bstein added a commit that referenced this issue Oct 6, 2022
@bstein
#231: Fix grid on Options page
8e871e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bstein bstein

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bstein @tijcolem