Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add playwright e2e tests #233

Merged
merged 63 commits into from
Dec 16, 2022
Merged

Add playwright e2e tests #233

merged 63 commits into from
Dec 16, 2022

Conversation

bstein
Copy link
Collaborator

@bstein bstein commented Oct 13, 2022

No description provided.

…gs, and add mocks folder with ipc main handle mocks
…al tests, and configure test script to prepare tmp files
bstein added 26 commits October 3, 2022 11:23
…timeout for some expect calls in run analysis tests
…sts to test analysis-type specific functionality
… by immediately removing handlers & limiting workers to 4
@tijcolem tijcolem requested a review from kflemin October 21, 2022 16:40
Copy link
Contributor

@kflemin kflemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I had to add the --retries flag locally when running the tests because one of the test would fail on each run, but adding the flag got them all to pass. I just added a line to the testing.md page to document that.

@tijcolem tijcolem merged commit 29cf1c8 into develop Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants