Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Availability Schedule for DaylightingControl #4364

Closed
lymereJ opened this issue Jun 21, 2021 · 2 comments · Fixed by #4365
Closed

Availability Schedule for DaylightingControl #4364

lymereJ opened this issue Jun 21, 2021 · 2 comments · Fixed by #4365

Comments

@lymereJ
Copy link

lymereJ commented Jun 21, 2021

Enhancement Request

Add an availability schedule field for the DaylightingControl object.

Detailed Description

The DaylightingControl object in OpenStudio doesn't appear to have an availability schedule field, but the EnergyPlus object does. An example for this field would be to turn off daylighting controls during sizing period/design day simulations. While this can be done using an EnergyPlus measures, it would be really useful to implement it when measures are not an option (e.g. openstudio-standards).

@lymereJ lymereJ added Enhancement Request Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Jun 21, 2021
@tijcolem tijcolem added component - Model and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Jun 23, 2021
@joseph-robertson joseph-robertson self-assigned this Jun 23, 2021
@joseph-robertson
Copy link
Collaborator

Should setters/getters for daylighting controls availability schedule be attached to DaylightingControl or to ThermalZone?

If they were attached to DaylightingControl, there would be separate primary and secondary availability schedules. What would the logic be for forward translating these into a single availability schedule on DaylightingControls in EnergyPlus?

If they were attached to ThermalZone, they'd apply to both the primary and secondary daylighting controls. What do we call the setters/getters? Something like daylightingControlsAvailabilitySchedule, setDaylightingControlsAvailabilitySchedule, etc?

@lymereJ
Copy link
Author

lymereJ commented Jun 24, 2021

Great questions! I feel like having them attached to DaylightingControl is the most logical approach, however, I'm not sure what strategy should be implemented in the forward translator. EnergyPlus only uses one availability schedule per Daylighting:Controls object, I doubt that multiple of these objects can be assigned to a same zone. So perhaps ThermalZone is a better choice. The setter/getter you propose seem good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants