Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #4364, Availability Schedule for DaylightingControl #4365

Merged
merged 6 commits into from
Jul 30, 2021

Conversation

joseph-robertson
Copy link
Collaborator

@joseph-robertson joseph-robertson commented Jun 24, 2021

Pull request overview

Adds to ThermalZone:

  • daylightingControlsAvailabilitySchedule
  • setDaylightingControlsAvailabilitySchedule
  • resetDaylightingControlsAvailabilitySchedule

Questions:

  • Do we need version translation if we're just adding a new optional field? Answer: since the new field is at the end, we don't need it.

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@joseph-robertson joseph-robertson added this to the OpenStudio SDK 3.3.0 milestone Jun 24, 2021
@joseph-robertson joseph-robertson self-assigned this Jun 24, 2021
@tijcolem tijcolem added the Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. label Jun 25, 2021
@joseph-robertson joseph-robertson requested a review from jmarrec June 25, 2021 22:07
@tijcolem tijcolem requested review from kbenne and removed request for jmarrec July 23, 2021 16:53
@kbenne kbenne merged commit c41c9f2 into develop Jul 30, 2021
@kbenne kbenne deleted the issue-4364 branch July 30, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component - Model Enhancement Request IDDChange Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Availability Schedule for DaylightingControl
4 participants