-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev scenario geospatial #97
Conversation
if two unique instances are created in the same notebook (i suspect current working dir as well) they will use the same saved information and not be able to have unique data for ex: create foo and add job "A" in the pipline, create bar and add job "B" in the pipline foo.pipeline = bar.pipeline => A = B the pipelines will be shared between class instances. only current soltution is to not declare more than one class in the same file (/directory?!?)
resets scenario. This is useful because the Scenario object stores its data in local files outside of the python script. This causes issues when two unique scenario instances are created in the same directory, they appear to be seperate instances to python but share the same data. Changes made to one are reflected in both.
potential: conflict between taking file path vs dataframe in func args.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #97 +/- ##
===============================================
- Coverage 67.02% 62.83% -4.20%
===============================================
Files 29 30 +1
Lines 2111 3024 +913
===============================================
+ Hits 1415 1900 +485
- Misses 696 1124 +428 ☔ View full report in Codecov by Sentry. |
Not sure if we've run into this before @martin-springer
When running with Note: we could also upgrade the pvlib version and change the test check values. Edit: Pvlib 0.11.0 released on June 21, 2024, which was after the last test passed on commit Edit: this appears to be the only test affected by the pvlib version so it would make sense to update the stored testing values rather than restricting ourselves to an older pvlib version. |
Dependency versioning issue again. This might be better as its own PR as it will affect all users with the newest scipy version.
|
…egradationTools into dev_scenario_geospatial
Describe your changes
Initial Scenario Analysis Integration. Sweeping scenario changes. New temperature function
temperature.temperature
that combines all temperature calculations (cell and module) into one function with support for all pvlib temperature models. All pvdeg functions preforming temperature calculations have been updated accordingly.Additionally
see pvlib docs <https://pvlib-python.readthedocs.io/en/stable/reference/pv_modeling/temperature.html>
scenario.Scenario
andscenario.GeospatialScenario
geospatial.identify_mountains_weights
,geospatial.identify_mountains_radii
,geospatial.feature_downselect
geospatial.apply_bounding_box
geospatial.elevation_stochastic_downselection
geospatial.identify_mountains_weights
GeospatialScenario.plot_coords
,GeospatialScenario.plot_meta_classification
GeospatialScenario.plot_USA
,Scenario.extract
,Scenario.plot
,GeospatialScenario.classify_mountain_weights
,GeospatialScenario.classify_mountain_radii
,GeospatialScenario.downselect_elevation_stochastic
Type of change
Please delete options that are not relevant.
Checklist before requesting a review