Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inital Geospatial Test #99

Merged
merged 6 commits into from
Aug 13, 2024
Merged

Conversation

tobin-ford
Copy link
Collaborator

@tobin-ford tobin-ford commented Jul 23, 2024

Describe your changes

pvdeg.geospatial.analysis standoff calculation test locally. Simple testing for a standoff analysis, autotemplating and conventional template tests. geospatial module has grown significantly with #97 but this PR includes the main functionality present in development currently.

Versioning issues should be fixed

After this is merged, geospatial scenario tests can be written using the files added to tests/data.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code
  • Code changes are covered by tests.
  • Code changes have been evaluated for compatibility/integration with Scenario analysis (for future PRs)
  • API.rst is up to date, along with other sphinx docs pages
  • What's new changelog has been updated in the docs

@tobin-ford tobin-ford added enhancement New feature or request and removed enhancement New feature or request labels Jul 23, 2024
@tobin-ford tobin-ford closed this Aug 1, 2024
@tobin-ford tobin-ford reopened this Aug 1, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 83.19328% with 20 lines in your changes missing coverage. Please review.

Project coverage is 69.11%. Comparing base (57cb222) to head (5404188).

Files Patch % Lines
pvdeg/geospatial.py 57.14% 12 Missing ⚠️
pvdeg/utilities.py 61.90% 8 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development      #99      +/-   ##
===============================================
+ Coverage        67.02%   69.11%   +2.08%     
===============================================
  Files               29       31       +2     
  Lines             2111     2215     +104     
===============================================
+ Hits              1415     1531     +116     
+ Misses             696      684      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martin-springer martin-springer merged commit acefdbf into development Aug 13, 2024
5 checks passed
@tobin-ford tobin-ford deleted the dev_geospatialtesting branch December 9, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants