Chp default bug #397
Merged
Chp default bug #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit de0d2cb.
zolanaj
approved these changes
May 21, 2024
There was a problem hiding this comment.
Thanks for this @hdunham! Approved with one question: Do you know if there are other potential issues where we may need to convert other than this? I think running conversions on all defaults inputs may be overkill, but I'm just wondering if there's something to watch for if we have maximums of vectors in future defaults population (or something similar).
I checked all the other instances of maximum and this is a one off bug |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
max_electric_load_kwto its expected type of Float64 (can be an Int) before passing to functionget_chp_defaults_prime_mover_size_class