-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.47.0 #403
v0.47.0 #403
Conversation
This reverts commit de0d2cb.
…'t kwh If not kwh then probably a formatting anomaly in urdb. In any case, I don't see the use in averaging the rates.
Chp default bug
This load_type was intended to provide default ratios of space heating and DHW heating for DOE commercial reference buildings We won't have a similar reference building to include process heat as well.
tax rate alignment
Updated Process Heat load structure
@hdunham should we switch the description of this to just point to the different PR's that were merged into develop? (and update to just putting everything under the one new version v0.47.0). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this was intended to be a swift approval and I didn't send it out. Approving pending @Bill-Becker's notes with a couple comments on the changelog.
@@ -23,6 +23,28 @@ Classify the change according to the following categories: | |||
### Deprecated | |||
### Removed | |||
|
|||
## v0.47.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just noting there is a version conflict between the changelog and the manifest.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also one other note: ProcessHeatLoad
was already part of the v46.0 update, so perhaps update that to BuiltInProcessHeatLoad
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zolanaj @Bill-Becker , let me know if there is anything i can do to help fix these inconsistencies. Since I can't change it directly on dev, I can start a branch if necessary to update the Changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I removed all of the redundant ones from v0.46.0 and replaced with a general description of what was added for ProcessHeatLoad, to supplement the other bullet points in the Updated section.
Enforce waste heat tracking
PRs: