Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when non standard value for "units" field in "energyratestructure" of URDB response #398

Merged
merged 10 commits into from
May 23, 2024

Conversation

hdunham
Copy link
Collaborator

@hdunham hdunham commented May 20, 2024

Changed

  • When the URDB response energyratestructure has a "unit" value that is not "kWh", throw an error instead of averaging rates in each energy tier.

hdunham added 5 commits May 17, 2024 15:31
…'t kwh

If not kwh then probably a formatting anomaly in urdb. In any case, I don't see the use in averaging the rates.
@hdunham hdunham requested a review from zolanaj May 21, 2024 16:42
@hdunham hdunham changed the title Remove special handling of non standard "units" field in "energyratestructure" of URDB response Error when non standard value for "units" field in "energyratestructure" of URDB response May 22, 2024
Copy link
Collaborator

@zolanaj zolanaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @hdunham! I added a test to ensure the exotic units are passed up to results. Assuming test pass (the last one was due to a timeout for PVWatts so might just need to be refreshed), this can be merged.

@hdunham hdunham merged commit 1fec0bb into develop May 23, 2024
3 checks passed
@hdunham hdunham deleted the urdb-unit-bug branch May 23, 2024 03:14
@Bill-Becker Bill-Becker mentioned this pull request May 30, 2024
indu-manogaran pushed a commit that referenced this pull request Sep 16, 2024
Error when non standard value for "units" field in "energyratestructure" of URDB response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants