-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.47.0 #403
Merged
Merged
v0.47.0 #403
Changes from 61 commits
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
ca42a9f
added comments for changes
bpulluta 2abc6cb
Merge branch 'industrial-process-heat' into add-process-heat-load
bpulluta a882bce
added built int process heat functionality
bpulluta 45a0ab2
updated simulated load
bpulluta 7e75341
adding results for process
bpulluta 40cf19a
updated process heat load inside thermal
bpulluta 48fed4b
updated process heat update
bpulluta c169e36
updated tests for process heat loads
bpulluta 78a2d1b
merge develop
bpulluta 20e7e25
merge from develop
bpulluta de0d2cb
Update .gitignore
hdunham c388903
add problem scenario to tests
hdunham 1b8918f
add scenario json
hdunham b0f72ac
check problem scenario erros
hdunham d02bbc9
convert max_electric_load_kw to float
hdunham 3e0cd21
check no error
hdunham 28145a6
remove debugging changes
hdunham 06f25b3
Revert "Update .gitignore"
hdunham 235972b
Update CHANGELOG.md
hdunham 85eff19
dont average rates in each energy tier when unit in urdb response isn…
hdunham e39cfed
rm unused var
hdunham dd5d0ed
Update CHANGELOG.md
hdunham a8c8955
Add third party factor multiplier to PV O&M results
lixiangk1 dad5387
Update CHANGELOG.md
lixiangk1 9defb8d
error when exotic energy tier units
hdunham 07be552
Update CHANGELOG.md
hdunham 4310414
supposed to be inside for loop
hdunham 80c0d62
Merge pull request #397 from NREL/chp-default-bug
hdunham 2848de8
Merge branch 'develop' into urdb-unit-bug
hdunham 5838381
Add test for exotic units detected
zolanaj e8ff44d
Merge branch 'develop' into pv_om_third_party_factor
adfarth d9780dd
Update CHANGELOG.md
adfarth e2c4670
Merge pull request #399 from NREL/pv_om_third_party_factor
adfarth 0a964a2
Merge branch 'develop' into urdb-unit-bug
hdunham ac4d9f3
fix changelog merge
hdunham 1fec0bb
Merge pull request #398 from NREL/urdb-unit-bug
hdunham 53cbc47
refactor heating flow constraints, move from storage to thermal_tech_…
zolanaj 46264a3
throw error if steam turbine is present but no techs can supply it
zolanaj e2e65ab
new testset "CHP to Waste Heat"
zolanaj 707cd70
fix tests in new set
zolanaj 266c278
Update CHANGELOG.md
zolanaj d5609d9
update version #s
hdunham 8e837dd
update constraint sets when turbine is present
zolanaj 77482fe
turn on presolve for CHP test
zolanaj 6e2ad5b
rm zero-size techs from test case (avoid PVWatts call)
zolanaj 2f2c935
tax rate update
adfarth 668384f
initiate PV in CHP cost curve test
zolanaj d79aecd
make CHP size test more flexible
zolanaj b79d14d
updated process heat tests
bpulluta 5cf7209
Merge branch 'develop' into add-process-heat-load
bpulluta c6ff82e
Updated runtest.jl with correct DotEnv variable
bpulluta e56be43
fixed scenario.jl for processheat to include lat-long
bpulluta 392fbb2
updated failing test from thermal_load
bpulluta 6d10800
updated heating loads test
bpulluta d6943f9
Fix type errors for blended_industrial_reference_ names and percents
Bill-Becker b07d4a9
Merge branch 'add-process-heat-load' of https://github.com/NREL/REopt…
Bill-Becker 614a512
Make separate load_type option for space_heating, dhw, and process_heat
Bill-Becker f228a91
Remove process_heat from load_type="heating"
Bill-Becker 5510760
Fix wrong file loading
Bill-Becker 4366454
Add expected ProcessHeatLoad to ElectricHeater test
Bill-Becker 85dcd22
Update simulated load test with updated process heat handling
Bill-Becker 9133b31
Merge pull request #407 from NREL/tax-rate
adfarth f0ec702
added process to emissions test
bpulluta 9ededdf
Update CHANGELOG.md
adfarth 3ede901
Merge branch 'develop' into add-process-heat-load
bpulluta c1eff6f
revert emission test for heating
bpulluta 7c522f4
updated changelog for process heat
bpulluta d1e85ec
updated changelog version for merging into develop
bpulluta 63e8eda
Merge branch 'develop' into enforce-waste-heat-tracking
zolanaj 418275f
Merge pull request #396 from NREL/add-process-heat-load
bpulluta 50b59ab
small fix to help text
adfarth 00d94cd
Merge branch 'master' into develop
Bill-Becker 9f5bf3c
Update CHANGELOG.md
Bill-Becker 556e30c
Update Project.toml to v0.47.0
Bill-Becker 1784d09
Merge branch 'develop' into enforce-waste-heat-tracking
zolanaj bd391d8
Merge pull request #404 from NREL/enforce-waste-heat-tracking
zolanaj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just noting there is a version conflict between the changelog and the manifest.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also one other note:
ProcessHeatLoad
was already part of the v46.0 update, so perhaps update that toBuiltInProcessHeatLoad
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zolanaj @Bill-Becker , let me know if there is anything i can do to help fix these inconsistencies. Since I can't change it directly on dev, I can start a branch if necessary to update the Changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I removed all of the redundant ones from v0.46.0 and replaced with a general description of what was added for ProcessHeatLoad, to supplement the other bullet points in the Updated section.