Add 90.1-2019 prototypes #1210
Merged
Add 90.1-2019 prototypes #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d Procedure MDP/system OA calculation for 90.1-2019.
…l-heating_gas_apply_efficiency_and_curves function to correctly set the furnace efficiency.
…ems. Fix minor unit typo in other part of the code.
…sed on IES horizontal illuminance values, and fix formatting.
…on to remain consistent with its original usage.
… that was incomplete/incorrect.
Pulling changes in nrcan_340 into nrcan_os320
lymereJ
added
the
90.1-2016/9
….1-2019 in the tests.
added check if there is no hourly data to output
Including 901_2016_2019 branch changes in nrcan_os320 branch
…iency' NECB method to 'heat_exchanger_air_to_air_sensible_and_latent_minimum_effectiveness' to harmonize with NREL and ensure it is being called properly. Removing 'git-revision' require statement from btap_datapoint.rb for merge with master.
Incorporating updates from nrcan branch
deleted commented out file - causes errors with gem install
mdahlhausen
reviewed
Sep 22, 2021
lib/openstudio-standards/prototypes/common/objects/Prototype.hvac_systems.rb
Outdated
Show resolved
Hide resolved
mdahlhausen
reviewed
Sep 22, 2021
update secondary area for daylighting test
unclear why the test was previously showing 0.792 W/ft2 as the target LPD
This is overloaded in necb methods and doesn't belong in hvac_systems
mdahlhausen
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed changes add the ASHRAE Standard 90.1-2019 prototypes to openstudio-standards. This includes all pull requests with the
90.1-2016/9tag that have been submitted previously.