Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Including changes in nrcan branch. #1491

Merged
merged 19 commits into from
Apr 4, 2023
Merged

Including changes in nrcan branch. #1491

merged 19 commits into from
Apr 4, 2023

Commits on Mar 8, 2023

  1. Modified model_add_daylighting_controls method in a way to set minimu… 

    …m lux value for each space type as per NECB
    @srgilani
    srgilani committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    1675086 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Modification of model_add_daylighting_controls method and unit test f… 

    …or it in progress; Updated bundler version in openstudio-standards.gemspec
    @srgilani
    srgilani committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    a41ca39 View commit details
    Browse the repository at this point in the history

  2. Modification of daylighting sensor control ECM and its unit test in p… 

    …rogress
    @srgilani
    srgilani committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    e6cb6d8 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Added min illuminance level to space_types.json of NECB2011; and NECB… 

    … 2015 in progress
    @srgilani
    srgilani committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    1091913 View commit details
    Browse the repository at this point in the history

  2. Modified unit test for daylighting sensor control ecm

    @srgilani
    srgilani committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    34a0ba5 View commit details
    Browse the repository at this point in the history

  3. Commented in unit test for daylighting sensor control ecm

    @srgilani
    srgilani committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    996f683 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Merge remote-tracking branch 'origin/nrcan' into nrcan_375

    @srgilani
    srgilani committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    0dbef25 View commit details
    Browse the repository at this point in the history

  2. Updated bundler version in openstudio-standards.gemspec

    @srgilani
    srgilani committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    c80a3e1 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Added min illuminance level to space_types.json of NECB2015

    @srgilani
    srgilani committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    8d61245 View commit details
    Browse the repository at this point in the history

  2. Adding min illuminance level to space_types.json of NECB2017, in prog… 

    …ress
    @srgilani
    srgilani committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    24cbdf1 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. Adding min illuminance level to space_types.json of NECB2017

    @srgilani
    srgilani committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    d24f49d View commit details
    Browse the repository at this point in the history

  2. Added min illuminance level to space_types.json of NECB2020

    @srgilani
    srgilani committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    66fafc3 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. Added min illuminance level to space_types.json of BTAPPRE1980 and BT… 

    …AP1980TO2010; Added units of min illuminance level to space_type_unit_definitions.txt; Added reference of min illuminance level to all space_types.json of necb
    @srgilani
    srgilani committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    b6b4217 View commit details
    Browse the repository at this point in the history

  2. Set daylighting_type in model_apply_standard method of necb_2011.rb; … 

    …Modified unit test for daylighting sensor control ecm and updated expected results for it
    @srgilani
    srgilani committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    21c1b1b View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/nrcan' into nrcan_375

    @srgilani
    srgilani committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    cf24c7e View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Updated expected results files of regression tests for warehouse, ret… 

    …ailstandalone, and smallhotel, due to changes in daylighting sensor control ecm
    @srgilani
    srgilani committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    4b7fff5 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Updated expected results files of regression tests for primary and se… 

    …condary school due to changes in daylighting sensor control ecm
    @srgilani
    srgilani committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    3a0d518 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. Merge pull request #1479 from NREL/nrcan_375: modify daylighting sens… 

    …or controls ECM

nrcan_375: modify daylighting sensor controls ECM
    @srgilani
    srgilani authored Apr 3, 2023
    Configuration menu
    Copy the full SHA
    3df5aee View commit details
    Browse the repository at this point in the history

  2. Nrcan 380 (#1489) 

    * replaced costing_enabled with intrinsic method to check if BTAPCosting is present

* replaced costing_enabled with intrinsic method to check if BTAPCosting is present
    @phylroy
    phylroy authored Apr 3, 2023
    Configuration menu
    Copy the full SHA
    c16ec80 View commit details
    Browse the repository at this point in the history